diff options
author | Szabolcs David <davidsz@inf.u-szeged.hu> | 2021-02-19 13:57:34 +0100 |
---|---|---|
committer | Szabolcs David <davidsz@inf.u-szeged.hu> | 2021-04-08 12:45:23 +0200 |
commit | d1398e734c927435f236c2eed36613bedf71acf6 (patch) | |
tree | a13da06003b6b142bd5f09e2be110f93f7cb1f3e /src/core/core_chromium.pri | |
parent | fb60a0638a47564c1a1e7c2933b699d0205c810e (diff) |
Fix embedded PDFs when plugins are disabled
Cover all cases from https://pdfobject.com/static
- Plugin placeholder is generally broken: displays garbage and crashes
on interaction. Fix it and show when PDFs are included by <embed>
or <object> tags.
- Do not start an automatical download when the disabled PDF plugin
was requested by an iframe. Show a clickable placeholder and let the
end-users start it manually.
- Remove unused class PluginPlaceholderQt
Task-number: QTBUG-76314
Change-Id: I01a0c93ab23f54e4272f5aeb30578de0dcf18932
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/core/core_chromium.pri')
-rw-r--r-- | src/core/core_chromium.pri | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/core/core_chromium.pri b/src/core/core_chromium.pri index 108dd3221..e978d20a1 100644 --- a/src/core/core_chromium.pri +++ b/src/core/core_chromium.pri @@ -113,7 +113,6 @@ SOURCES = \ renderer/web_engine_page_render_frame.cpp \ renderer/render_configuration.cpp \ renderer/user_resource_controller.cpp \ - renderer/plugins/plugin_placeholder_qt.cpp \ renderer_host/web_engine_page_host.cpp \ renderer_host/user_resource_controller_host.cpp \ resource_bundle_qt.cpp \ @@ -218,7 +217,6 @@ HEADERS = \ renderer/web_engine_page_render_frame.h \ renderer/render_configuration.h \ renderer/user_resource_controller.h \ - renderer/plugins/plugin_placeholder_qt.h \ renderer_host/web_engine_page_host.h \ renderer_host/user_resource_controller_host.h \ request_controller.h \ @@ -326,6 +324,7 @@ qtConfig(webengine-extensions) { extensions/extensions_browser_client_qt.cpp \ extensions/messaging_delegate_qt.cpp \ extensions/mime_handler_view_guest_delegate_qt.cpp \ + extensions/pdf_iframe_navigation_throttle_qt.cpp \ extensions/plugin_service_filter_qt.cpp \ net/plugin_response_interceptor_url_loader_throttle.cpp \ renderer/extensions/extensions_dispatcher_delegate_qt.cpp \ @@ -345,6 +344,7 @@ qtConfig(webengine-extensions) { extensions/extensions_browser_client_qt.h \ extensions/messaging_delegate_qt.h \ extensions/mime_handler_view_guest_delegate_qt.h \ + extensions/pdf_iframe_navigation_throttle_qt.h \ extensions/plugin_service_filter_qt.h \ net/plugin_response_interceptor_url_loader_throttle.h \ renderer/extensions/extensions_dispatcher_delegate_qt.h \ |