diff options
| author | Laszlo Agocs <laszlo.agocs@qt.io> | 2018-02-18 18:09:55 +0100 |
|---|---|---|
| committer | Laszlo Agocs <laszlo.agocs@qt.io> | 2018-02-19 12:17:42 +0000 |
| commit | 041ad7cf63ebcbfd5048a758965105dd86df97d4 (patch) | |
| tree | 66fe4a8a9fda414b0a49ccf35e211fc67efff2fd /src/runtime/q3dsanimationmanager.cpp | |
| parent | 04556936ac800c46c492ffea28dd45b3e9deb69f (diff) | |
Make the two uses of Q3DSPropertyChange distinct in the API
A Q3DSPropertyChangeList can be used in two ways:
1. passed both to applyPropertyChanges and notifyPropertyChanges
In this case both the property name and value must be set, obviously.
2. when passed only to notifyPropertyChanges
Here there is no value since the new values are expected to be already set
via some other mechanism (i.e. the static setters in case of animations).
As a first step towards cleaning up how values are get/set for graph
object members, make this distinction obvious in Q3dSPropertyChange.
Change-Id: I96afe73932ad272426b9cbc511b6f596a0e8ed87
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Diffstat (limited to 'src/runtime/q3dsanimationmanager.cpp')
| -rw-r--r-- | src/runtime/q3dsanimationmanager.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/q3dsanimationmanager.cpp b/src/runtime/q3dsanimationmanager.cpp index ee025dc..4b85584 100644 --- a/src/runtime/q3dsanimationmanager.cpp +++ b/src/runtime/q3dsanimationmanager.cpp @@ -794,7 +794,7 @@ void Q3DSAnimationManager::applyChanges() if (Q_UNLIKELY(animDebug)) qDebug() << "animate:" << target->id() << it->name << it->value; it->setter(target, it->value, it->name); - changeList.append(Q3DSPropertyChange(it->name, QString())); + changeList.append(Q3DSPropertyChange(it->name)); ++it; } if (!changeList.isEmpty()) |