diff options
author | Christian Strømme <christian.stromme@qt.io> | 2018-08-27 23:17:10 +0200 |
---|---|---|
committer | Laszlo Agocs <laszlo.agocs@qt.io> | 2018-08-28 13:01:28 +0000 |
commit | 7aed790d66a468dbd5c58813fafe1cef2630333b (patch) | |
tree | 3b4ad245d0ad5c1bb483f16ed645b5e295cab90f /src/runtime/q3dsuippresentation.cpp | |
parent | 1697bc09229e12f8e4b2b3db6c4881ae679015ab (diff) |
Fix usage of wrong index variable when removing dynamic properties
The index for the static property values was used, which could in
worst case cause a crash.
Change-Id: Iab428990a73fca9f659184a171f3ecc0363fada6
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'src/runtime/q3dsuippresentation.cpp')
-rw-r--r-- | src/runtime/q3dsuippresentation.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/q3dsuippresentation.cpp b/src/runtime/q3dsuippresentation.cpp index a704662..23836f0 100644 --- a/src/runtime/q3dsuippresentation.cpp +++ b/src/runtime/q3dsuippresentation.cpp @@ -810,7 +810,7 @@ bool Q3DSGraphObject::setProperty(const char *name, const QVariant &v) if (v.isValid()) extraMetaData()->data->propertyValues[propIdx] = v; else - extraMetaData()->data->propertyNames.remove(idx); + extraMetaData()->data->propertyNames.remove(propIdx); } else if (v.isValid()) { extraMetaData()->data->propertyNames.push_back(name); extraMetaData()->data->propertyValues.push_back(v); |