diff options
author | Christian Strømme <christian.stromme@qt.io> | 2018-09-07 16:53:07 +0200 |
---|---|---|
committer | Laszlo Agocs <laszlo.agocs@qt.io> | 2018-09-11 08:07:22 +0000 |
commit | 156a70ee5dcacba34039e80d2cff158348de717a (patch) | |
tree | a7ddfea3a8ec2f6ec7c3ab9fc2a645bb99ee9bbe /src/runtime/q3dsuippresentation_p.h | |
parent | e18f373992186f7dbe570bffc2f14cbc0cb29b8f (diff) |
More const and detached avoidance
Calling these functions should not have side-effects on their objects,
and are potential bottlenecks, so avoid detaching unnecessarily.
Change-Id: Ibbe067f1c24af669bb7db7238b354cdbf998bf1d
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'src/runtime/q3dsuippresentation_p.h')
-rw-r--r-- | src/runtime/q3dsuippresentation_p.h | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/runtime/q3dsuippresentation_p.h b/src/runtime/q3dsuippresentation_p.h index f51d1e1..ee1210c 100644 --- a/src/runtime/q3dsuippresentation_p.h +++ b/src/runtime/q3dsuippresentation_p.h @@ -327,7 +327,7 @@ public: virtual void applyPropertyChanges(const Q3DSPropertyChangeList &changeList); virtual void resolveReferences(Q3DSUipPresentation &) { } - virtual int mapChangeFlags(const Q3DSPropertyChangeList &changeList); + virtual int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const; void notifyPropertyChanges(const Q3DSPropertyChangeList &changeList); bool isNode() const { return m_type >= FirstNodeType; } @@ -793,7 +793,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; void resolveReferences(Q3DSUipPresentation &pres) override; void calculateTextureTransform(); @@ -908,7 +908,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; Flags flags() const { return m_flags; } // Properties @@ -1077,7 +1077,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // non-uip, for internal use bool hasExplicitSize() const { return m_layerFlags.testFlag(ExplicitSize); } @@ -1416,7 +1416,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; void resolveReferences(Q3DSUipPresentation &pres) override; // Properties @@ -1527,7 +1527,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // Properties QString text() const { return m_text; } @@ -1632,7 +1632,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // Properties ShaderLighting shaderLighting() const { return m_shaderLighting; } @@ -1784,7 +1784,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // Properties Q3DSGraphObject *referencedMaterial() const { return m_referencedMaterial; } @@ -1838,7 +1838,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // Properties QString sourcePath() const { return m_material_unresolved; } @@ -1895,7 +1895,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; // Properties QString sourcePath() const { return m_effect_unresolved; } @@ -1933,7 +1933,7 @@ public: void setProperties(const QXmlStreamAttributes &attrs, PropSetFlags flags) override; void applyPropertyChanges(const Q3DSPropertyChangeList &changeList) override; void resolveReferences(Q3DSUipPresentation &pres) override; - int mapChangeFlags(const Q3DSPropertyChangeList &changeList) override; + int mapChangeFlags(const Q3DSPropertyChangeList &changeList) const override; QString qmlErrorString() const { return m_qmlErrorString; } void setQmlErrorString(const QString &error) { m_qmlErrorString = error; } |