summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiikka Heikkinen <miikka.heikkinen@qt.io>2018-07-05 15:25:08 +0300
committerMiikka Heikkinen <miikka.heikkinen@qt.io>2018-07-05 12:37:35 +0000
commit7b5d36e0bfcdcc37bf634f60ccf0978386ce0bec (patch)
tree677078099be58227b7575561333d561479188db8
parent1bf2df5b328e38bbae1dccc4a19d15494dd66782 (diff)
Minor code cleanup
Remove unnecessary IDataModelListener usage from Qt3DSDMTimelineItemBinding. Change-Id: Ie33b128ba28a1e8664c94239cbd489e6f4b32b3d Reviewed-by: Mahmoud Badri <mahmoud.badri@qt.io> Reviewed-by: Jere Tuliniemi <jere.tuliniemi@qt.io> Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
-rw-r--r--src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.cpp30
-rw-r--r--src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.h10
2 files changed, 1 insertions, 39 deletions
diff --git a/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.cpp b/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.cpp
index 5956c78d..fdafdd3c 100644
--- a/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.cpp
+++ b/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.cpp
@@ -70,7 +70,6 @@ Qt3DSDMTimelineItemBinding::Qt3DSDMTimelineItemBinding(CTimelineTranslationManag
{
m_StudioSystem = m_TransMgr->GetStudioSystem();
- m_TransMgr->GetDoc()->GetCore()->GetDispatch()->AddDataModelListener(this);
}
Qt3DSDMTimelineItemBinding::Qt3DSDMTimelineItemBinding(CTimelineTranslationManager *inMgr)
@@ -80,14 +79,12 @@ Qt3DSDMTimelineItemBinding::Qt3DSDMTimelineItemBinding(CTimelineTranslationManag
, m_TimelineTimebar(nullptr)
{
m_StudioSystem = m_TransMgr->GetStudioSystem();
- m_TransMgr->GetDoc()->GetCore()->GetDispatch()->AddDataModelListener(this);
}
Qt3DSDMTimelineItemBinding::~Qt3DSDMTimelineItemBinding()
{
RemoveAllPropertyBindings();
delete m_TimelineTimebar;
- m_TransMgr->GetDoc()->GetCore()->GetDispatch()->RemoveDataModelListener(this);
}
// helpers
@@ -758,33 +755,6 @@ long Qt3DSDMTimelineItemBinding::GetFlavor() const
return QT3DS_FLAVOR_ASSET_TL;
}
-void Qt3DSDMTimelineItemBinding::OnBeginDataModelNotifications()
-{
-}
-void Qt3DSDMTimelineItemBinding::OnEndDataModelNotifications()
-{
- RefreshStateRow();
-}
-void Qt3DSDMTimelineItemBinding::OnImmediateRefreshInstanceSingle(
- qt3dsdm::Qt3DSDMInstanceHandle inInstance)
-{
- if (inInstance == m_DataHandle)
- RefreshStateRow(true);
-}
-void Qt3DSDMTimelineItemBinding::OnImmediateRefreshInstanceMultiple(
- qt3dsdm::Qt3DSDMInstanceHandle *inInstance, long inInstanceCount)
-{
- for (long idx = 0; idx < inInstanceCount; ++idx)
- if (inInstance[idx] == m_DataHandle) {
- RefreshStateRow();
- break;
- }
-}
-
-void Qt3DSDMTimelineItemBinding::RefreshStateRow(bool inRefreshChildren)
-{
-}
-
ITimelineTimebar *Qt3DSDMTimelineItemBinding::CreateTimelineTimebar()
{
return new Qt3DSDMTimelineTimebar(m_TransMgr, m_DataHandle);
diff --git a/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.h b/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.h
index 198ec8a3..8fd89f19 100644
--- a/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.h
+++ b/src/Authoring/Studio/Palettes/Timeline/Bindings/Qt3DSDMTimelineItemBinding.h
@@ -65,8 +65,7 @@ class CStudioSystem;
*/
class Qt3DSDMTimelineItemBinding : public ITimelineItemBinding,
public ITimelineItem,
- public IDragable,
- public IDataModelListener
+ public IDragable
{
protected: // Typedef
@@ -154,13 +153,6 @@ public:
// IDragable
long GetFlavor() const override;
- void OnBeginDataModelNotifications() override;
- void OnEndDataModelNotifications() override;
- void OnImmediateRefreshInstanceSingle(qt3dsdm::Qt3DSDMInstanceHandle inInstance) override;
- void OnImmediateRefreshInstanceMultiple(qt3dsdm::Qt3DSDMInstanceHandle *inInstance,
- long inInstanceCount) override;
- void RefreshStateRow(bool inRefreshChildren = false);
-
virtual void AddPropertyRow(qt3dsdm::Qt3DSDMPropertyHandle inPropertyHandle,
bool inAppend = false);
virtual void RemovePropertyRow(qt3dsdm::Qt3DSDMPropertyHandle inPropertyHandle);