summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjasplin <qt-info@nokia.com>2011-02-24 11:31:44 +0100
committerjasplin <qt-info@nokia.com>2011-02-24 11:31:44 +0100
commit4d27ab2be55ad21cc6249a042753f61e6161b833 (patch)
tree64b2033b08dc693b7ead81ce66f6ee84d28eaae1
parentf420006666977578d0138a63798c0284979d89fe (diff)
Fixed bug.
When computing the quality score for a time series, an invalid LSD or MDRSE (indicated by -1) should contribute a max quality score since each of them _normally_ arises when analyzing a time series that is very short, and thus not really qualifying as being of "poor quality" yet.
-rwxr-xr-xscripts/finalizeresults.py4
-rw-r--r--web/getstats/global.js4
2 files changed, 4 insertions, 4 deletions
diff --git a/scripts/finalizeresults.py b/scripts/finalizeresults.py
index 8b32365..ec7c156 100755
--- a/scripts/finalizeresults.py
+++ b/scripts/finalizeresults.py
@@ -54,11 +54,11 @@ def qualityScore(lsd, ni, nz, nc, mdrse):
max_NZ = max_bad_snapshots * max_sample_size;
max_NC = max_bad_snapshots;
- lsd_score = min(1, lsd / float(max_LSD));
+ lsd_score = 0 if (lsd == -1) else min(1, lsd / float(max_LSD));
ni_score = min(1, ni / float(max_NI));
nz_score = min(1, nz / float(max_NZ));
nc_score = min(1, nc / float(max_NC));
- mdrse_score = mdrse / 100.0;
+ mdrse_score = 0 if (mdrse == -1) else (mdrse / 100.0);
return (lsd_score + ni_score + nz_score + nc_score + mdrse_score) / 5.0;
diff --git a/web/getstats/global.js b/web/getstats/global.js
index 50d745c..1a4148d 100644
--- a/web/getstats/global.js
+++ b/web/getstats/global.js
@@ -76,11 +76,11 @@ function qualityScore(lsd, ni, nz, nc, mdrse) {
var maxNZ = maxBadSnapshots * maxSampleSize;
var maxNC = maxBadSnapshots;
- var lsdScore = Math.min(1, lsd / maxLSD);
+ var lsdScore = (lsd == -1) ? 0 : Math.min(1, lsd / maxLSD);
var niScore = Math.min(1, ni / maxNI);
var nzScore = Math.min(1, nz / maxNZ);
var ncScore = Math.min(1, nc / maxNC);
- var mdrseScore = mdrse / 100;
+ var mdrseScore = (mdrse == -1) ? 0 : (mdrse / 100);
return (lsdScore + niScore + nzScore + ncScore + mdrseScore) / 5;
}