qgetenv: Limit scope to variables to if-statement if possibleupstream/work/alex/stuff

Otherwise, it is a bit confusing which variables are only relevant for throwaway-checks

1 files changed, 2 insertions, 6 deletions

diff --git a/src/checks/level0/qgetenv.cpp b/src/checks/level0/qgetenv.cpp
index 6c05434f..28afa7c2 100644
--- a/src/checks/level0/qgetenv.cpp
+++ b/src/checks/level0/qgetenv.cpp
@@ -49,8 +49,7 @@ void QGetEnv::VisitStmt(clang::Stmt *stmt)
         return;
     }
 
-    CXXRecordDecl *record = method->getParent();
-    if (!record || clazy::name(record) != "QByteArray") {
+    if (CXXRecordDecl *record = method->getParent(); !record || clazy::name(record) != "QByteArray") {
         return;
     }
 
@@ -60,10 +59,7 @@ void QGetEnv::VisitStmt(clang::Stmt *stmt)
     }
 
     CallExpr *qgetEnvCall = calls.back();
-
-    FunctionDecl *func = qgetEnvCall->getDirectCallee();
-
-    if (!func || clazy::name(func) != "qgetenv") {
+    if (FunctionDecl *func = qgetEnvCall->getDirectCallee(); !func || clazy::name(func) != "qgetenv") {
         return;
     }