diff options
author | Katja Marttila <katja.marttila@qt.io> | 2018-05-28 11:52:24 +0300 |
---|---|---|
committer | Katja Marttila <katja.marttila@qt.io> | 2018-05-29 09:40:18 +0000 |
commit | d5be955bbb6cf595f7f6c30c4b1904c153a4d7c7 (patch) | |
tree | dc87c9d794a81c036c88e993203d886ab08974ed | |
parent | f27a9e14d0b4a0e5c39b25162abed9cc793baa41 (diff) |
Print component warnings only in verbose mode
If there are lot of components, it takes a lot of time to check every
component for their errors. Print those only when --verbose given in
command line.
Task-number: QTIFW-975
Change-Id: If9467416d5d8f3417cd30262f95e91308a79e7a6
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
-rw-r--r-- | src/libs/installer/packagemanagercore_p.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index 1cd7811c7..78482b411 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -406,11 +406,14 @@ bool PackageManagerCorePrivate::buildComponentTree(QHash<QString, Component*> &c restoreCheckState(); - foreach (QInstaller::Component *component, components) { - const QStringList warnings = ComponentChecker::checkComponent(component); - foreach (const QString &warning, warnings) - qCWarning(lcComponentChecker).noquote() << warning; + if (m_core->isVerbose()) { + foreach (QInstaller::Component *component, components) { + const QStringList warnings = ComponentChecker::checkComponent(component); + foreach (const QString &warning, warnings) + qCWarning(lcComponentChecker).noquote() << warning; + } } + } catch (const Error &error) { clearAllComponentLists(); emit m_core->finishAllComponentsReset(QList<QInstaller::Component*>()); |