diff options
author | Katja Marttila <katja.marttila@qt.io> | 2021-01-14 15:51:31 +0200 |
---|---|---|
committer | Katja Marttila <katja.marttila@qt.io> | 2021-01-20 10:39:13 +0200 |
commit | 220d11862631f3ae75db19e7acd61fe555e42b22 (patch) | |
tree | 7d16921c420d3afda43e44afebe4411d3b821f30 | |
parent | c3a84add1c8ed3c879168cba4e9a84af58129da6 (diff) |
Remove double calculation of uninstall components
This speeds up selecting/unselecting items in updater view around 25
procent.
Task-number: QTIFW-1021
Change-Id: Ia50f7f1d47da0f03fbd6d66b6e78482225545230
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
-rw-r--r-- | src/libs/installer/uninstallercalculator.cpp | 5 | ||||
-rw-r--r-- | src/libs/installer/uninstallercalculator.h | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/src/libs/installer/uninstallercalculator.cpp b/src/libs/installer/uninstallercalculator.cpp index 4823af012..668ace699 100644 --- a/src/libs/installer/uninstallercalculator.cpp +++ b/src/libs/installer/uninstallercalculator.cpp @@ -125,7 +125,12 @@ void UninstallerCalculator::appendComponentsToUninstall(const QList<Component*> if (!autoDependOnList.isEmpty()) appendComponentsToUninstall(autoDependOnList); + else + continueAppendComponentsToUninstall(); +} +void UninstallerCalculator::continueAppendComponentsToUninstall() +{ QList<Component*> unneededVirtualList; // Check for virtual components without dependees foreach (Component *component, m_installedComponents) { diff --git a/src/libs/installer/uninstallercalculator.h b/src/libs/installer/uninstallercalculator.h index cb4fe1ff6..a684c92cc 100644 --- a/src/libs/installer/uninstallercalculator.h +++ b/src/libs/installer/uninstallercalculator.h @@ -51,6 +51,7 @@ public: private: void appendComponentToUninstall(Component *component); + void continueAppendComponentsToUninstall(); QList<Component *> m_installedComponents; QSet<Component *> m_componentsToUninstall; |