summaryrefslogtreecommitdiffstats
path: root/src/libs/installer/componentchecker.cpp
diff options
context:
space:
mode:
authorJarek Kobus <jaroslaw.kobus@theqtcompany.com>2015-04-20 15:09:18 +0200
committerJarek Kobus <jaroslaw.kobus@theqtcompany.com>2015-04-24 12:56:14 +0000
commit61bf0345cdc86dc4053a5c2c1c3f782b5fd970ed (patch)
treec2edca6d088108ccf57416c4e0f10dec57c59b68 /src/libs/installer/componentchecker.cpp
parent930cc36e499205c28f66f6fcae6ddc8946c4f697 (diff)
Add more explanations on warnings we issue.
Change-Id: I7fea8d8c5ebc1ffea78635c335a0740c648b8e2e Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com> Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Diffstat (limited to 'src/libs/installer/componentchecker.cpp')
-rw-r--r--src/libs/installer/componentchecker.cpp27
1 files changed, 27 insertions, 0 deletions
diff --git a/src/libs/installer/componentchecker.cpp b/src/libs/installer/componentchecker.cpp
index 0f4ec20e7..2b806a5b4 100644
--- a/src/libs/installer/componentchecker.cpp
+++ b/src/libs/installer/componentchecker.cpp
@@ -115,6 +115,19 @@ QStringList ComponentChecker::checkComponent(Component *component)
}
if (component->childCount()) {
if (!autoDependencies.isEmpty()) {
+ /* Use case:
+
+ A (depends on C)
+ A.B
+ C
+
+ Let's say we installed everything.
+ Running maintenance tool and unselecting C will mark A for uninstallation too,
+ while A.B stays marked as installed.
+ After running maintenance tool again, it will check A automatically
+ (since its child is selected), this will also mark C for installation (dependecy).
+ Moreover, the "Next" button will be disabled.
+ */
checkResult << QString::fromLatin1("Component %1 auto depends on other components "
"while having children components. This will not work properly.")
.arg(component->name());
@@ -127,6 +140,20 @@ QStringList ComponentChecker::checkComponent(Component *component)
}
if (!core->dependees(component).isEmpty()) {
+ /*
+ Use case:
+
+ A
+ A.B
+ C (depends on A)
+
+ Selecting C marks A for installation too, A.B is not marked for installation.
+ So after installation, A and C are installed, while A.B is not.
+ Maintenance tool will uncheck A automatically
+ (since none of its children are installed) this will also mark C
+ for uninstallation (dependency).
+ Moreover, the "Next" button will be disabled.
+ */
checkResult << QString::fromLatin1("Other components depend on component %1 "
"which has children components. This will not work properly.")
.arg(component->name());