diff options
author | Katja Marttila <katja.marttila@qt.io> | 2020-02-18 13:55:25 +0200 |
---|---|---|
committer | Katja Marttila <katja.marttila@qt.io> | 2020-02-20 07:37:12 +0000 |
commit | 6163fc05768b6a7d05530ef5c33d8f024ebd6b6d (patch) | |
tree | cabc13d262a32fa5b7417fbbead9bf60a4cf795c /src/libs/installer/fileutils.cpp | |
parent | 276d8aafe9410f82c6c342f060332e5bba44fecd (diff) |
CLI: decrease the amount of default debug prints
Debug prints can be suppressed or extended with logging rules. Make the
default usage so that only relevant information will be shown to user,
such as uninstall/install progress, server information, warning messages
and package name, version and displayname.
Change-Id: I09be754a36dd97530d75cdea3edb5fc77e67a856
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Diffstat (limited to 'src/libs/installer/fileutils.cpp')
-rw-r--r-- | src/libs/installer/fileutils.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/libs/installer/fileutils.cpp b/src/libs/installer/fileutils.cpp index 7829083e4..c72a45c1e 100644 --- a/src/libs/installer/fileutils.cpp +++ b/src/libs/installer/fileutils.cpp @@ -189,7 +189,7 @@ void QInstaller::removeFiles(const QString &path, bool ignoreErrors) QDir::toNativeSeparators(f.fileName()), f.errorString()); if (!ignoreErrors) throw Error(errorMessage); - qCWarning(QInstaller::lcGeneral).noquote() << errorMessage; + qCWarning(QInstaller::lcInstallerInstallLog).noquote() << errorMessage; } } } @@ -232,7 +232,7 @@ void QInstaller::removeDirectory(const QString &path, bool ignoreErrors) errnoToQString(errno)); if (!ignoreErrors) throw Error(errorMessage); - qCWarning(QInstaller::lcGeneral).noquote() << errorMessage; + qCWarning(QInstaller::lcInstallerInstallLog).noquote() << errorMessage; } } } @@ -313,14 +313,14 @@ bool QInstaller::setDefaultFilePermissions(const QString &fileName, DefaultFileP bool QInstaller::setDefaultFilePermissions(QFile *file, DefaultFilePermissions permissions) { if (!file->exists()) { - qCWarning(QInstaller::lcGeneral) << "Target" << file->fileName() << "does not exists."; + qCWarning(QInstaller::lcInstallerInstallLog) << "Target" << file->fileName() << "does not exists."; return false; } if (file->permissions() == static_cast<QFileDevice::Permission>(permissions)) return true; if (!file->setPermissions(static_cast<QFileDevice::Permission>(permissions))) { - qCWarning(QInstaller::lcGeneral) << "Cannot set default permissions for target" + qCWarning(QInstaller::lcInstallerInstallLog) << "Cannot set default permissions for target" << file->fileName() << ":" << file->errorString(); return false; } @@ -530,13 +530,13 @@ void QInstaller::setApplicationIcon(const QString &application, const QString &i { QFile iconFile(icon); if (!iconFile.open(QIODevice::ReadOnly)) { - qCWarning(QInstaller::lcGeneral) << "Cannot use" << icon << "as an application icon:" + qCWarning(QInstaller::lcInstallerInstallLog) << "Cannot use" << icon << "as an application icon:" << iconFile.errorString(); return; } if (QImageReader::imageFormat(icon) != "ico") { - qCWarning(QInstaller::lcGeneral) << "Cannot use" << icon << "as an application icon, " + qCWarning(QInstaller::lcInstallerInstallLog) << "Cannot use" << icon << "as an application icon, " "unsupported format" << QImageReader::imageFormat(icon).constData(); return; } |