Fix clang and compiler warnings

Added const and reference to function names, removed unused
variables etc.

Change-Id: I5e3851c13ff3baf1884356198020fc86e69d69b4
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/libs/installer/installercalculator.cpp b/src/libs/installer/installercalculator.cpp
index 83efeb468..f285158f8 100644
--- a/src/libs/installer/installercalculator.cpp
+++ b/src/libs/installer/installercalculator.cpp
@@ -327,7 +327,7 @@ QSet<Component *> InstallerCalculator::autodependencyComponents(const bool rever
     return foundAutoDependOnList;
 }
 
-void InstallerCalculator::calculateComponentDependencyReferences(const QString dependencyComponentName, const Component *component)
+void InstallerCalculator::calculateComponentDependencyReferences(const QString &dependencyComponentName, const Component *component)
 {
     Component *dependencyComponent = m_core->componentByName(dependencyComponentName);
     if (!dependencyComponent || component->autoDependencies().contains(dependencyComponentName))
@@ -338,8 +338,8 @@ void InstallerCalculator::calculateComponentDependencyReferences(const QString d
 
     const QStringList dependenciesList = dependencyComponent->currentDependencies();
     for (const QString &depComponentName : dependenciesList) {
-        Component *dependencyComponent = m_core->componentByName(depComponentName);
-        calculateComponentDependencyReferences(depComponentName, dependencyComponent);
+        Component *depComponent = m_core->componentByName(depComponentName);
+        calculateComponentDependencyReferences(depComponentName, depComponent);
     }
 }