Fix bugs in InstallIconsOperation and add unit tests

- Fix conflicting naming and reference of operation value in
  InstallIconsOperation::targetDirectory().
- Fix bug related to appending of "icons" suffix to paths in
  XDG_DATA_HOME, the logic was glued to old default values which have
  been since changed.
- Remove unused variable in class destructor and remove unneeded
  default implementation.

Also add unit and CLI tests for InstallIconsOperation and move
addToFileMap() to common functions so it can be used in multiple tests.

Task-number: QTIFW-1715
Task-number: QTIFW-1465
Change-Id: I5281ca7a5dec1453f49fbe2cb2852d6467bf0c97
Reviewed-by: Katja Marttila <katja.marttila@qt.io>

1 files changed, 1 insertions, 2 deletions

diff --git a/src/libs/installer/installiconsoperation.h b/src/libs/installer/installiconsoperation.h
index 5f8dff514..7a4d1cc90 100644
--- a/src/libs/installer/installiconsoperation.h
+++ b/src/libs/installer/installiconsoperation.h
@@ -1,6 +1,6 @@
 /**************************************************************************
 **
-** Copyright (C) 2017 The Qt Company Ltd.
+** Copyright (C) 2020 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the Qt Installer Framework.
@@ -40,7 +40,6 @@ class INSTALLER_EXPORT InstallIconsOperation : public QObject, public Operation
     Q_OBJECT
 public:
     explicit InstallIconsOperation(PackageManagerCore *core);
-    ~InstallIconsOperation();
 
     void backup();
     bool performOperation();