Support detecting invalid dependency resolutions on component selection

IFW could already previously detect circular and missing dependencies by
running a precheck calculation when building the component tree.
However, there can be also cases of where the user selection results in
unsolvable changes to components.

One such case was the erroneous possibility to uninstall a component
marked with ForcedInstallation, if any of its dependencies was checkable
and the user unselected it for uninstallation.

Add support for reacting to such errors in the component tree view,
displaying a message box about the invalid dependency resolvation error,
and blocking further navigation until the component selection passes
the dependency calculations.

Also attempt some refactoring the related code to simplify the different
call sequences resulting in recalculation of the components.

Change-Id: I9dc78f858bd4be7932f89f8e14bbfd97fbd3a0f6
Reviewed-by: Katja Marttila <katja.marttila@qt.io>

1 files changed, 4 insertions, 33 deletions

diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp
index d9a35bcb1..6d56791a0 100644
--- a/src/libs/installer/packagemanagercore_p.cpp
+++ b/src/libs/installer/packagemanagercore_p.cpp
@@ -1,6 +1,6 @@
 /**************************************************************************
 **
-** Copyright (C) 2022 The Qt Company Ltd.
+** Copyright (C) 2023 The Qt Company Ltd.
 ** Contact: https://www.qt.io/licensing/
 **
 ** This file is part of the Qt Installer Framework.
@@ -170,7 +170,6 @@ PackageManagerCorePrivate::PackageManagerCorePrivate(PackageManagerCore *core)
     , m_updateSourcesAdded(false)
     , m_magicBinaryMarker(0) // initialize with pseudo marker
     , m_magicMarkerSupplement(BinaryContent::Default)
-    , m_componentsToInstallCalculated(false)
     , m_componentScriptEngine(nullptr)
     , m_controlScriptEngine(nullptr)
     , m_installerCalculator(nullptr)
@@ -209,7 +208,6 @@ PackageManagerCorePrivate::PackageManagerCorePrivate(PackageManagerCore *core, q
     , m_updateSourcesAdded(false)
     , m_magicBinaryMarker(magicInstallerMaker)
     , m_magicMarkerSupplement(BinaryContent::Default)
-    , m_componentsToInstallCalculated(false)
     , m_componentScriptEngine(nullptr)
     , m_controlScriptEngine(nullptr)
     , m_installerCalculator(nullptr)
@@ -496,7 +494,6 @@ void PackageManagerCorePrivate::clearAllComponentLists()
     m_deletedReplacedComponents.clear();
 
     m_componentsToReplaceAllMode.clear();
-    m_componentsToInstallCalculated = false;
 
     qDeleteAll(toDelete);
     cleanUpComponentEnvironment();
@@ -521,7 +518,6 @@ void PackageManagerCorePrivate::clearUpdaterComponentLists()
     m_updaterDependencyReplacements.clear();
 
     m_componentsToReplaceUpdaterMode.clear();
-    m_componentsToInstallCalculated = false;
 
     qDeleteAll(usedComponents);
     cleanUpComponentEnvironment();
@@ -586,7 +582,6 @@ void PackageManagerCorePrivate::initialize(const QHash<QString, QString> &params
 {
     m_coreCheckedHash.clear();
     m_data = PackageManagerCoreData(params, isInstaller());
-    m_componentsToInstallCalculated = false;
 
 #ifdef Q_OS_LINUX
     if (m_launchedAsRoot && isInstaller())
@@ -2915,7 +2910,6 @@ void PackageManagerCorePrivate::restoreCheckState()
     }
 
     m_coreCheckedHash.clear();
-    m_componentsToInstallCalculated = false;
 }
 
 void PackageManagerCorePrivate::storeCheckState()
@@ -3056,12 +3050,12 @@ QStringList PackageManagerCorePrivate::runningInstallerProcesses(const QStringLi
 
 bool PackageManagerCorePrivate::calculateComponentsAndRun()
 {
-    QString htmlOutput;
-    bool componentsOk = m_core->calculateComponents(&htmlOutput);
+    bool componentsOk = m_core->recalculateAllComponents();
     if (statusCanceledOrFailed()) {
         qCDebug(QInstaller::lcInstallerInstallLog) << "Installation canceled.";
     } else if (componentsOk && acceptLicenseAgreements()) {
-        qCDebug(QInstaller::lcInstallerInstallLog).noquote() << htmlToString(htmlOutput);
+        qCDebug(QInstaller::lcInstallerInstallLog).noquote()
+            << htmlToString(m_core->componentResolveReasons());
 
         QString spaceInfo;
         const bool spaceOk = m_core->checkAvailableSpace(spaceInfo);
@@ -3078,29 +3072,6 @@ bool PackageManagerCorePrivate::calculateComponentsAndRun()
     return false;
 }
 
-void PackageManagerCorePrivate::calculateUninstallComponents()
-{
-    clearUninstallerCalculator();
-    const QList<Component *> componentsToInstallList = installerCalculator()->orderedComponentsToInstall();
-    QSet<Component*> componentsToInstall(componentsToInstallList.begin(), componentsToInstallList.end());
-
-    QList<Component *> selectedComponentsToUninstall;
-    foreach (Component* component, m_core->components(PackageManagerCore::ComponentType::Replacements)) {
-        // Uninstall the component if replacement is selected for install or update
-        QPair<Component*, Component*> comp = componentsToReplace().value(component->name());
-        if (comp.first && m_installerCalculator->orderedComponentsToInstall().contains(comp.first)) {
-            uninstallerCalculator()->insertUninstallReason(component,
-                UninstallerCalculator::Replaced, comp.first->name());
-            selectedComponentsToUninstall.append(comp.second);
-        }
-    }
-    foreach (Component *component, m_core->components(PackageManagerCore::ComponentType::AllNoReplacements)) {
-        if (component->uninstallationRequested() && !componentsToInstallList.contains(component))
-            selectedComponentsToUninstall.append(component);
-    }
-    uninstallerCalculator()->appendComponentsToUninstall(selectedComponentsToUninstall);
-}
-
 bool PackageManagerCorePrivate::acceptLicenseAgreements() const
 {
     // Always skip for uninstaller