diff options
| author | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2020-12-02 16:36:26 +0200 |
|---|---|---|
| committer | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2021-02-16 13:16:52 +0200 |
| commit | 8997ec51b7603fafe5cd34dcff21ba1151c76f32 (patch) | |
| tree | 0e07bb85141d742f2e3b327f410129685afade99 /src/libs/installer/packagemanagercore_p.cpp | |
| parent | 5b55a71adb283d8e335cd724c2b7b66acf3551a5 (diff) | |
Add unit tests for offline generation
This also changes some of the return values in our CLI-related
functions in PackageManagerCore class to better catch cases
where we exit without failing but also without doing anything.
Also adapt existing tests.
Task-number: QTIFW-2028
Change-Id: I73c4ca1b20d439773d0e290195f137d0d7369d17
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Diffstat (limited to 'src/libs/installer/packagemanagercore_p.cpp')
| -rw-r--r-- | src/libs/installer/packagemanagercore_p.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp index fea032ab1..f4670c738 100644 --- a/src/libs/installer/packagemanagercore_p.cpp +++ b/src/libs/installer/packagemanagercore_p.cpp @@ -459,6 +459,7 @@ bool PackageManagerCorePrivate::buildComponentTree(QHash<QString, Component*> &c clearInstallerCalculator(); if (installerCalculator()->appendComponentsToInstall(components.values()) == false) { + setStatus(PackageManagerCore::Failure, installerCalculator()->componentsToInstallError()); MessageBoxHandler::critical(MessageBoxHandler::currentBestSuitParent(), QLatin1String("Error"), tr("Unresolved dependencies"), installerCalculator()->componentsToInstallError()); return false; |