diff options
| author | Katja Marttila <katja.marttila@qt.io> | 2018-11-23 07:01:15 +0200 |
|---|---|---|
| committer | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2021-01-15 14:56:26 +0200 |
| commit | c3a84add1c8ed3c879168cba4e9a84af58129da6 (patch) | |
| tree | 54cdc5142e8043af98372bb5527f0c5dec6280ab /src/libs/installer/performinstallationform.cpp | |
| parent | 57078aec62049ac08c5df94db06c79e956fd0eeb (diff) | |
Replace usage of derived LazyPlainTextEdit class with QTextEdit
Remove LazyPlainTextEdit class and replace usage in
PerformInstallationForm details browser to QTextEdit. This adds
support for RTL text alignment as the base class of the removed
class, QPlainTextEdit does not fully support RTL and automatic
alignment. Text will now be automatically aligned based on the
direction of the characters.
This also improves the usability of the details browser, as it
does not force scrolling to bottom if the user has scrolled the
widget contents to inspect previous lines.
Task-number: QTIFW-1994
Change-Id: If01eaea121000edc0b5039edfede88ffb7bacd6f
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Diffstat (limited to 'src/libs/installer/performinstallationform.cpp')
| -rw-r--r-- | src/libs/installer/performinstallationform.cpp | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/libs/installer/performinstallationform.cpp b/src/libs/installer/performinstallationform.cpp index f60ef0ab1..2fb6026cc 100644 --- a/src/libs/installer/performinstallationform.cpp +++ b/src/libs/installer/performinstallationform.cpp @@ -28,7 +28,6 @@ #include "performinstallationform.h" -#include "lazyplaintextedit.h" #include "progresscoordinator.h" #include "globals.h" @@ -147,7 +146,7 @@ void PerformInstallationForm::setupUi(QWidget *widget) m_productImagesScrollArea->setWidget(m_productImagesLabel); bottomLayout->addWidget(m_productImagesScrollArea); - m_detailsBrowser = new LazyPlainTextEdit(widget); + m_detailsBrowser = new QTextEdit(widget); m_detailsBrowser->setReadOnly(true); m_detailsBrowser->setWordWrapMode(QTextOption::NoWrap); m_detailsBrowser->setObjectName(QLatin1String("DetailsBrowser")); @@ -269,14 +268,6 @@ void PerformInstallationForm::setDetailsButtonEnabled(bool enable) } /*! - Scrolls to the bottom of the details browser. -*/ -void PerformInstallationForm::scrollDetailsToTheEnd() -{ - m_detailsBrowser->updateCursor(LazyPlainTextEdit::TextCursorPosition::ForceEnd); -} - -/*! Returns \c true if the details browser is visible. */ bool PerformInstallationForm::isShowingDetails() const |