diff options
| author | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2023-12-22 13:29:45 +0200 |
|---|---|---|
| committer | Arttu Tarkiainen <arttu.tarkiainen@qt.io> | 2023-12-27 09:53:14 +0200 |
| commit | 58e96428a20d654477d6731c789fd127e2eb3a7f (patch) | |
| tree | 8b22ce8e1f2cf5760e7383726ac1bb63cbe36d48 /src/libs/installer | |
| parent | 8aa07f23a8e1b07349c9f0f62910f3bf8e8eb616 (diff) | |
Fix automatic page switching on offline generation
There was a missing connection of signal
PackageManagerCore::offlineGenerationFinished to
slot PackageManagerGui::showFinishedPage.
This caused the installer to prevent navigating forward after
successfully creating an offline installer, in case the details view
was hidden. If the details view was shown, the Cancel button was
also incorrectly still enabled.
Adding the missing signal connection fixes both issues.
Task-number: QTIFW-3237
Change-Id: Idf7f24aae354fdfb09106e595f8b8fc312bfd817
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Diffstat (limited to 'src/libs/installer')
| -rw-r--r-- | src/libs/installer/packagemanagergui.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/libs/installer/packagemanagergui.cpp b/src/libs/installer/packagemanagergui.cpp index ab2b5b007..e0a66f49a 100644 --- a/src/libs/installer/packagemanagergui.cpp +++ b/src/libs/installer/packagemanagergui.cpp @@ -412,10 +412,13 @@ PackageManagerGui::PackageManagerGui(PackageManagerCore *core, QWidget *parent) connect(this, &QDialog::rejected, m_core, &PackageManagerCore::setCanceled); connect(this, &PackageManagerGui::interrupted, m_core, &PackageManagerCore::interrupt); - // both queued to show the finished page once everything is done + // all queued to show the finished page once everything is done connect(m_core, &PackageManagerCore::installationFinished, this, &PackageManagerGui::showFinishedPage, Qt::QueuedConnection); + connect(m_core, &PackageManagerCore::offlineGenerationFinished, + this, &PackageManagerGui::showFinishedPage, + Qt::QueuedConnection); connect(m_core, &PackageManagerCore::uninstallationFinished, this, &PackageManagerGui::showFinishedPage, Qt::QueuedConnection); |