Use QFileInfo::exists() as that is documented to be faster

Change-Id: I413669860334d96de684c1c32962a33166ac6c7c
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>

8 files changed, 14 insertions, 14 deletions

diff --git a/src/libs/ifwtools/binarycreator.cpp b/src/libs/ifwtools/binarycreator.cpp
index 839e469d2..52603cad5 100644
--- a/src/libs/ifwtools/binarycreator.cpp
+++ b/src/libs/ifwtools/binarycreator.cpp
@@ -704,13 +704,13 @@ int QInstallerTools::createBinary(BinaryCreatorArgs args, QString &argumentError
 
     // Begin check arguments
     foreach (const QString &packageDir, args.packagesDirectories) {
-        if (!QFileInfo(packageDir).exists()) {
+        if (!QFileInfo::exists(packageDir)) {
             argumentError = QString::fromLatin1("Error: Package directory not found at the specified location.");
             return EXIT_FAILURE;
         }
     }
     foreach (const QString &repositoryDir, args.repositoryDirectories) {
-        if (!QFileInfo(repositoryDir).exists()) {
+        if (!QFileInfo::exists(repositoryDir)) {
             argumentError = QString::fromLatin1("Error: Only local filesystem repositories now supported.");
             return EXIT_FAILURE;
         }
@@ -721,12 +721,12 @@ int QInstallerTools::createBinary(BinaryCreatorArgs args, QString &argumentError
             "contain any components apart from the root component.");
         return EXIT_FAILURE;
     }
-    if (!QFileInfo(args.templateBinary).exists()) {
+    if (!QFileInfo::exists(args.templateBinary)) {
 #ifdef Q_OS_WIN
         if (!args.templateBinary.endsWith(suffix))
             args.templateBinary = args.templateBinary + suffix;
         // Try again with added executable suffix
-        if (!QFileInfo(args.templateBinary).exists()) {
+        if (!QFileInfo::exists(args.templateBinary)) {
             argumentError = QString::fromLatin1("Error: Template base binary not found at the specified location.");
             return EXIT_FAILURE;
         }
diff --git a/src/libs/ifwtools/binarycreator.h b/src/libs/ifwtools/binarycreator.h
index 779725660..387195742 100644
--- a/src/libs/ifwtools/binarycreator.h
+++ b/src/libs/ifwtools/binarycreator.h
@@ -77,7 +77,7 @@ public:
     explicit BundleBackup(const QString &bundle = QString())
         : bundle(bundle)
     {
-        if (!bundle.isEmpty() && QFileInfo(bundle).exists()) {
+        if (!bundle.isEmpty() && QFileInfo::exists(bundle)) {
             backup = QInstaller::generateTemporaryFileName(bundle);
             QFile::rename(bundle, backup);
         }
diff --git a/src/libs/installer/createlinkoperation.cpp b/src/libs/installer/createlinkoperation.cpp
index 3f29367b6..65ff8fc5d 100644
--- a/src/libs/installer/createlinkoperation.cpp
+++ b/src/libs/installer/createlinkoperation.cpp
@@ -88,7 +88,7 @@ bool CreateLinkOperation::undoOperation()
         return false;
     }
 
-    return !QFileInfo(linkPath).exists();
+    return !QFileInfo::exists(linkPath);
 }
 
 bool CreateLinkOperation::testOperation()
diff --git a/src/libs/installer/fileutils.cpp b/src/libs/installer/fileutils.cpp
index ebef3495d..16502383c 100644
--- a/src/libs/installer/fileutils.cpp
+++ b/src/libs/installer/fileutils.cpp
@@ -371,7 +371,7 @@ bool QInstaller::setDefaultFilePermissions(QFile *file, DefaultFilePermissions p
 void QInstaller::copyDirectoryContents(const QString &sourceDir, const QString &targetDir)
 {
     Q_ASSERT(QFileInfo(sourceDir).isDir());
-    Q_ASSERT(!QFileInfo(targetDir).exists() || QFileInfo(targetDir).isDir());
+    Q_ASSERT(!QFileInfo::exists(targetDir) || QFileInfo(targetDir).isDir());
     if (!QDir().mkpath(targetDir)) {
         throw Error(QCoreApplication::translate("QInstaller", "Cannot create directory \"%1\".")
             .arg(QDir::toNativeSeparators(targetDir)));
@@ -402,7 +402,7 @@ void QInstaller::copyDirectoryContents(const QString &sourceDir, const QString &
 void QInstaller::moveDirectoryContents(const QString &sourceDir, const QString &targetDir)
 {
     Q_ASSERT(QFileInfo(sourceDir).isDir());
-    Q_ASSERT(!QFileInfo(targetDir).exists() || QFileInfo(targetDir).isDir());
+    Q_ASSERT(!QFileInfo::exists(targetDir) || QFileInfo(targetDir).isDir());
     if (!QDir().mkpath(targetDir)) {
         throw Error(QCoreApplication::translate("QInstaller", "Cannot create directory \"%1\".")
             .arg(QDir::toNativeSeparators(targetDir)));
diff --git a/src/libs/installer/packagemanagercore.cpp b/src/libs/installer/packagemanagercore.cpp
index 7687ce13c..3e19d6b81 100644
--- a/src/libs/installer/packagemanagercore.cpp
+++ b/src/libs/installer/packagemanagercore.cpp
@@ -1048,7 +1048,7 @@ bool PackageManagerCore::isFileExtensionRegistered(const QString &extension) con
  */
 bool PackageManagerCore::fileExists(const QString &filePath) const
 {
-    return QFileInfo(filePath).exists();
+    return QFileInfo::exists(filePath);
 }
 
 /*!
diff --git a/src/libs/installer/packagemanagercore_p.cpp b/src/libs/installer/packagemanagercore_p.cpp
index 368f9aaae..cbf7813a7 100644
--- a/src/libs/installer/packagemanagercore_p.cpp
+++ b/src/libs/installer/packagemanagercore_p.cpp
@@ -1404,7 +1404,7 @@ void PackageManagerCorePrivate::writeMaintenanceTool(OperationList performedOper
         bool newBinaryWritten = false;
         QString mtName = maintenanceToolName();
         const QString installerBaseBinary = replaceVariables(m_installerBaseBinaryUnreplaced);
-        if (!installerBaseBinary.isEmpty() && QFileInfo(installerBaseBinary).exists()) {
+        if (!installerBaseBinary.isEmpty() && QFileInfo::exists(installerBaseBinary)) {
             qCDebug(QInstaller::lcInstallerInstallLog) << "Got a replacement installer base binary:"
                 << installerBaseBinary;
             if (QInstaller::isInBundle(installerBaseBinary)) {
@@ -1455,7 +1455,7 @@ void PackageManagerCorePrivate::writeMaintenanceTool(OperationList performedOper
                 }
             }
             m_installerBaseBinaryUnreplaced.clear();
-        } else if (!installerBaseBinary.isEmpty() && !QFileInfo(installerBaseBinary).exists()) {
+        } else if (!installerBaseBinary.isEmpty() && !QFileInfo::exists(installerBaseBinary)) {
             qCWarning(QInstaller::lcInstallerInstallLog) << "The current maintenance tool could not be updated."
                 << installerBaseBinary << "does not exist. Please fix the \"setInstallerBaseBinary"
                 "(<temp_installer_base_binary_path>)\" call in your script.";
@@ -2177,7 +2177,7 @@ bool PackageManagerCorePrivate::runOfflineGenerator()
         m_core->downloadNeededArchives(double(1));
 
         const QString installerBaseReplacement = replaceVariables(m_offlineBaseBinaryUnreplaced);
-        if (!installerBaseReplacement.isEmpty() && QFileInfo(installerBaseReplacement).exists()) {
+        if (!installerBaseReplacement.isEmpty() && QFileInfo::exists(installerBaseReplacement)) {
             qCDebug(QInstaller::lcInstallerInstallLog) << "Got a replacement installer base binary:"
                 << offlineBinaryTempName;
 
diff --git a/src/libs/installer/sysinfo_win.cpp b/src/libs/installer/sysinfo_win.cpp
index e6c2a0be8..e74eb1d4e 100644
--- a/src/libs/installer/sysinfo_win.cpp
+++ b/src/libs/installer/sysinfo_win.cpp
@@ -150,7 +150,7 @@ QList<VolumeInfo> mountedVolumes()
 
 bool pathIsOnLocalDevice(const QString &path)
 {
-    if (!QFileInfo(path).exists())
+    if (!QFileInfo::exists(path))
         return false;
 
     if (path.startsWith(QLatin1String("//")))
diff --git a/src/libs/kdtools/lockfile_win.cpp b/src/libs/kdtools/lockfile_win.cpp
index 20961cc4e..7fc808d39 100644
--- a/src/libs/kdtools/lockfile_win.cpp
+++ b/src/libs/kdtools/lockfile_win.cpp
@@ -45,7 +45,7 @@ bool LockFile::Private::lock()
 
     errorString.clear();
     handle = CreateFile(filename.toStdWString().data(), GENERIC_READ | GENERIC_WRITE,
-        FILE_SHARE_READ, NULL, QFileInfo(filename).exists() ? OPEN_EXISTING : CREATE_NEW,
+        FILE_SHARE_READ, NULL, QFileInfo::exists(filename) ? OPEN_EXISTING : CREATE_NEW,
         FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_TEMPORARY | FILE_FLAG_DELETE_ON_CLOSE, NULL);
 
     if (handle == INVALID_HANDLE_VALUE) {