| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Also if the log contains links or html, added link interaction
possibility and correct html syntax to messagebox and error messages.
Task-number: QTIFW-3012
Change-Id: Ibf20f50c0f06fdbb8325f93dbdf78ba36d4fe4e5
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
| |
Productkeycheck, or repository, can implement additional license checkings. Added possibility to enable the next button in license agreement page when productkeycheck has also validated that the license check is ok. By default productkeycheck returns true for additional license checks, the developer can override the productkeycheck to add additional checks.
Task-number: QTIFW-3319
Change-Id: Ie7e3d84eb800edb6c5c9731afa6bfe464e4ae4d1
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
| |
We need to access the core functionality despite of what user interface
is used.
Change-Id: I6c4c7e8526ff24a479128061aa40fba66e61660c
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the button texts in installer are not something that is
suitable. Added possibility to change button texts from script to a
specific installer page.
Task-number: QTIFW-711
Change-Id: I2883cda6d770843c3617fda4e6b07d102a357730
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|\
| |
| |
| | |
Change-Id: Id9fe7a127a72b58732f5dffd11c4c9c7c1c56060
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In case the user chose to generate offline installer by clicking the
"Create Offline Installer" button on ComponentSelectionPage, navigating
back to the page did not reset the internal binary marker. This made
it impossible to perform a normal installation afterwards.
Fix by resetting the state on ComponentSelectionPage::entering().
Task-number: QTIFW-3236
Change-Id: I0951ec90e70dff9e8e233dee0cc5592c5c509c28
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was a missing connection of signal
PackageManagerCore::offlineGenerationFinished to
slot PackageManagerGui::showFinishedPage.
This caused the installer to prevent navigating forward after
successfully creating an offline installer, in case the details view
was hidden. If the details view was shown, the Cancel button was
also incorrectly still enabled.
Adding the missing signal connection fixes both issues.
Task-number: QTIFW-3237
Change-Id: Idf7f24aae354fdfb09106e595f8b8fc312bfd817
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|/
|
|
|
|
|
|
|
|
| |
The subtitle in component selection page is long and is chopped into two
lines by QWizard. Chop the title from more suitable place for it to show
up nicely.
Task-number: QTIFW-3102
Change-Id: I6d45864a6b162922d0f461620fab75eea7baa98c
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was supposed to be part of the
798f844242f855a46a082abacf6c4c4175f10eca change, but got missed. The
reference to the installer itself has been changed from 'Wizard' or
'Setup Wizard' to just 'Setup' everywhere to ensure consistent wording
being used through the UI.
Task-Name: SQUISH-9672
Change-Id: I866cc9616a2bcca731068721c243d3579451773e
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|\
| |
| |
| | |
Change-Id: Idadf4fb3047f72880e5a86f76eb21b659589cd17
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Components are refetch when fetching the categories, thus we need to
recalculate the installable components
Task-number: QTIFW-3085
Change-Id: Ie794e6308dd7f3f96814781d8e25769ecd323887
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was previously possible only from the CLI. The same methods
can be used from the graphical installer, so we do not need to
limit the feature for CLI users.
Task-number: QTIFW-3072
Change-Id: I271aecf163528b922e6cc399d31f07218e2a1650
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
The page title text did not match the text located in the sidebar.
Task-number: QTIFW-3060
Change-Id: If435aeb0b2ddbdcafed43c4da61702f3d5bf7688
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When error occurs during component fetch, for example cache is in use or
another metadata parsing error, installer allowed to continue
to uninstall existing components. This has confused users, as there is no
place to show error message and users had no idea why not all components
were visible in the tree. The error message was only written to logs.
Fixed this by showing the error message in 'Add or remove/Update' -page
and not allowing to continue to uninstall existing components.
Task-number: QTIFW-3069
Change-Id: I9f7d96d04b150c319b01d6e61430805128d3c31a
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|/
|
|
|
|
|
| |
To get rid of [-Wreorder] warnings
Change-Id: I2b0b071100eeb1830017da2913b62c00a18823bd
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The title of the page was replicating that product name and the word
'Setup', but was not doing so consistently with either the message text
or the title. Since the titles of the other pages do not refer the product
and the product is mentioned in the message too, lets make this a short
'Welcome' instead.
Since this is vastly different from the original text, I decided to adjust
all translations for this string to unfinished - except for the german one
which I can easily contribute myself.
Task-Name: SQUISH-9672
Change-Id: Ia410d6e256b59b858f54082d17513a0b58a18546
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
Reviewed-by: Tino Pyssysalo <tino.pyssysalo@qt.io>
|
|\ |
|
| |\
| | |
| | |
| | | |
Change-Id: I9946bf8ff3ea4e132a0490b59c1d4d557198ef62
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
showSettingsButton() called from control script had no effect.
Fixed it so that if showSettingsButton will overwrite the IFW
decision to show the settings button.
Change-Id: Ia08c03cc13db58168fd371f230517bcc83ee0e12
Task-number: QTIFW-810
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Part of the installer UI refresh spec.
Task-number: QTIFW-2995
Change-Id: I8256ec12410831edbb7c7e36cb4f2af15287891c
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If pagelist item is not the current item, make the item disabled so it
can be correctly painted in the stylesheet
Task-number: QTIFW-2989
Change-Id: Ifb4c9a95061ff30f0ea842bc0d706f7960baaf20
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I07baba6a0e64b6022e6a933708e199551be7dd2f
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
IFW could already previously detect circular and missing dependencies by
running a precheck calculation when building the component tree.
However, there can be also cases of where the user selection results in
unsolvable changes to components.
One such case was the erroneous possibility to uninstall a component
marked with ForcedInstallation, if any of its dependencies was checkable
and the user unselected it for uninstallation.
Add support for reacting to such errors in the component tree view,
displaying a message box about the invalid dependency resolvation error,
and blocking further navigation until the component selection passes
the dependency calculations.
Also attempt some refactoring the related code to simplify the different
call sequences resulting in recalculation of the components.
Change-Id: I9dc78f858bd4be7932f89f8e14bbfd97fbd3a0f6
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTIFW-1829
Change-Id: Ibb492ada102dd74f4defde084fca48106837add6
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ia8717933439359e23b65d9465dec8c70fbe59ee2
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: Id8121e6b4cdda23c8c44cf779e35dce8d9a28090
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
TabController would invoke IntroductionPage::onCoreNetworkSettings-
Changed() slot, which would disable the UI controls for selecting the
package manager or updater mode in case the maintenance tool is
configured to use only temporary repositories that are set only later
on. This would also update the internal magic marker indicating the
binary type, overwriting the user selected one that was passed with
one of the --start-* options.
Fix by splitting the resetting of the "metadata fetched" state of the
page to its own public method from IntroductionPage::onCoreNetwork-
SettingsChanged(), and call that from the TabController initialization
instead.
Task-number: QTIFW-2884
Change-Id: I952b8fd1d14e6292bae1556a5f33dec537c8b1d6
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
| |
This change adds attribute, postLoad, to existing <Script> -element.
Using <Script postLoad="True"> will call the script loading and
evaluation only to those components which are selected for install or
update right before the components installation start.
Task-number: QTIFW-2820
Change-Id: Ic1967d329cbb5de6a0216ff3f76cc2ede178db80
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The text was using just the word 'Setup' which is inconsistent with other
places which usually refer to the application as '<product> Setup'. Adding
the product name would've been possible, but it seemed unnecessary to
repeat the installer name again right at the last step. So instead replace
that with a general message explaining that all needed information has been
collected.
Task-Name: SQUISH-9672
Change-Id: Ia253f4f921431f272bc1d69352a5fa7179e84d0c
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a maintenance tool that has no configured repositories, we can
disable the selection of package manager and updater options, that
require at least one repository to be useful.
Also show the settings button for offline maintenance tool that is run
in uninstaller mode, because the user may want to add a new repository
which then enables the disabled options.
Task-number: QTIFW-2627
Change-Id: I4db7f6526c37bbadeaf680fe9cb6130058ca5ffd
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In many other places the UI refers to the program as just '<Product> Setup'
and the 'Wizard' suffix also seems to be somewhat out of date/'retro'.
So get rid of the suffix to make the naming more consistent.
I think this change also fixes a problem with translation. The ts-files
contain just 'Completing the %1 Setup' for the Restart Page, while the
actual text is 'Completing the %1 Setup Wizard'. So the translation here
might not have worked properly - it certainly looked odd.
Task-Name: SQUISH-9672
Change-Id: I65a56c6e927f01307868ad8319e301b84ab330be
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We print the component list to gui in 'ready to install' page and
to console when using install/remove commands. Add the same print
to installationlog.txt so that it easier to spot possible installation errors.
Task-number: QTIFW-2666
Change-Id: Icea96695e3d3a4516d65c7b487ed5fced2701632
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Some licenses use ASCII art to display tables, etc. which requires
that the font is of fixed width.
Task-number: QTIFW-2613
Change-Id: I0f473e6320912702c5df01d99a573ee820da3c1b
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Components were recalculated when leaving the tree view. This is
unnecessary as we have just calculated the components. Moving the
recalculation to Introduction page so alternate pressing of 'Add or
remove components' and 'Update components' will cause the recalculation
as we need that to keep the component install states in sync.
Task-number: QTIFW-2598
Task-number: QTIFW-694
Change-Id: Ia84a01b4f1d0b39b4844c02470b764c4940e943c
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The "Cancel" button on bottom of the wizard is also missing a shortcut.
But this behavior is inherited from QWizard, where it appears to be
intentional.
Task-number: QTIFW-2206
Change-Id: I53e595591679f5d22b2b381f86974dfc963d2bd4
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Product image can now be clicked. It opens either url in Web browser or
if file reference is given, then it will be opened with the suitable
application.
Task-number: QTIFW-2361
Change-Id: I59ed1355e90c23c8d0a5124779725825ca1ee2c8
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Add where missing. Replace occurrences of Q_DECL_OVERRIDE macro,
building IFW requires a C++11 compatible compiler so the language
specifier is preferred.
Change-Id: Idb75e2813d26b9da85e03891f0ae9537c6524c56
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing QWizard::NoDefaultButton will enable enter clicking in macos.
This will also keep the Spacebar -key press to accept the Next -button.
Adding also Qt::StrongFocus to Next -button, otherwise for example the
radio buttons in Introduction -page will get the Spacebar -key press, even
when those are set invisible, causing the installer to be converted to
package manager.
Task-number: QTIFW-2409
Change-Id: I2ad0e98b5be635c2f9e53ec1b6262bd37be22cae
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTIFW-2437
Change-Id: I3c0293550456f36e37e98e97042bf6bfae6ce96d
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also enable linking qtimageformats as a static plugin on macOS,
it is required to read the .icns file to be shown on the dialog.
Task-number: QTIFW-2453
Change-Id: Ib776635167a4c90ffa20a91ecc447d2d73f5aeb9
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
| |
Next should be the default selection when use presses Enter. Sometimes
the focus was in Settings button.
Task-number: QTIFW-1046
Change-Id: Idae996bd5a0c511b9d2595a22b7ea0114f34ade1
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTIFW-2439
Change-Id: Ie8f7a35d73d847e8864b1f1f2dc5fb7bc8ed9092
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a disparency in the return value of QFileInfo::isFile() on
Windows whether QFileInfo uses QFileSystemEngine directly (for local
files, returns false) or with another file engine (QFSFileEngine in this
case, returns true), when the file does not exist on disk.
Installer registers its own file engine handler that handles file
engine creation. It creates custom RemoteFileEngine instances suitable
for writing into more restrictive locations when the connection to the
elevated installer server process is active.
When calling RemoteFileEngine::fileFlags() with TypesMask parameter, the
returned combination of enum values includes FileFlag::FileType when
the given file does not exist, this can be reproduced with both the
active remote server connection that forwards the file engine calls to
the server process, and when the composed QFSFileEngine object is used
directly without the remote connection.
Fix by adding a check if the given target directory path exists, if it
doesn't we can assume it is a directory to be created by the installer.
Also rename function to better match what it does.
Task-number: QTIFW-2383
Change-Id: I906b0676802d9d94e70abeb2dea1f71866cbbec8
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prefer elided text to horizontal scrolling. Fix invalid size hint for
side widget items, otherwise the item delegate will compute the size
hint based on the item data. We want to include custom height to not
make the list cramped.
Task-number: QTIFW-2388
Change-Id: I490a12c04f921b8c9a01c3ac72c6bcd4d951f6d3
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|\
| |
| |
| | |
Change-Id: I8e2864b3ec81cffa907fe02ff1f2019e155c54e3
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ComponentSelectionPage::isComplete() would return false if the state of
the component model was "DefaultChecked" and user had not (de)selected
any new components. This change adds a condition to check if there are
any ForcedInstallation components that haven't been previously
installed, and allows navigating forward and installing those without
additional selections.
Task-number: QTIFW-2286
Change-Id: I273cc7219df1eae4e11ff23e733d71a9c297bedd
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTIFW-2245
Change-Id: Id9a79c7c572dc588c05ad37c67ae3f0431fa7cdb
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTIFW-2244
Change-Id: Ib3c717eb7fd76bdc928072630177c71933e8aef1
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageBoxHandler will decide an appropriate parent widget for new
QMessageBox objects just before they are shown. This is not quaranteed
to be a PackageManagerGui instance, for example when the installer
wizard does not have focus, which means the style properties do not
get inherited.
Rather set the used style sheet for the whole application using
QApplication::setStyleSheet().
Task-number: QTIFW-2121
Change-Id: I6f2131279d6f6d3dd41b9eacab8404770aad09a3
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|
|
|
|
|
|
| |
Task-number: QTIFW-2150
Change-Id: I8a216ed99aaa68347558cb90a712d2afd1147268
Reviewed-by: Katja Marttila <katja.marttila@qt.io>
|