1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
|
/*
* Copyright (C) 2014-2015 Canonical, Ltd.
*
* This program is free software: you can redistribute it and/or modify it under
* the terms of the GNU Lesser General Public License version 3, as published by
* the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranties of MERCHANTABILITY,
* SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include <qteventfeeder.h>
#include <debughelpers.h>
#include <QGuiApplication>
#include <QWindow>
#include "mir/events/event_builders.h"
#include "mock_qtwindowsystem.h"
using ::testing::_;
using ::testing::AllOf;
using ::testing::AnyNumber;
using ::testing::Contains;
using ::testing::AtLeast;
using ::testing::InSequence;
using ::testing::Mock;
using ::testing::SizeIs;
using ::testing::Return;
// own gmock extensions
using ::testing::IsPressed;
using ::testing::IsStationary;
using ::testing::IsReleased;
using ::testing::HasId;
using ::testing::StateIsMoved;
namespace mev = mir::events;
// used by google mock in error messages
void PrintTo(const struct QWindowSystemInterface::TouchPoint& touchPoint, ::std::ostream* os) {
*os << "TouchPoint("
<< "id=" << touchPoint.id
<< "," << touchPointStateToString(touchPoint.state)
<< ")";
}
::std::ostream& operator<<(::std::ostream& os, QTouchDevice*) {
// actually don't care about its contents. Just to avoit having a raw
// pointer address being printed in google mock error messages.
return os << "QTouchDevice*";
}
class QtEventFeederTest : public ::testing::Test {
protected:
void SetUp() override;
void TearDown() override;
void setIrrelevantMockWindowSystemExpectations();
MockQtWindowSystem *mockWindowSystem;
QtEventFeeder *qtEventFeeder;
};
void QtEventFeederTest::SetUp()
{
mockWindowSystem = new MockQtWindowSystem;
EXPECT_CALL(*mockWindowSystem, registerTouchDevice(_));
qtEventFeeder = new QtEventFeeder(mockWindowSystem);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
}
void QtEventFeederTest::TearDown()
{
// mockWindowSystem will be deleted by QtEventFeeder
delete qtEventFeeder;
}
void QtEventFeederTest::setIrrelevantMockWindowSystemExpectations()
{
EXPECT_CALL(*mockWindowSystem, hasTargetWindow())
.Times(AnyNumber())
.WillRepeatedly(Return(true));
EXPECT_CALL(*mockWindowSystem, targetWindowGeometry())
.Times(AnyNumber())
.WillRepeatedly(Return(QRect(0,0,100,100)));
}
/*
Mir sends a MirEvent([touch(id=0,state=pressed)]. QtEventFeeder happily forwards that to Qt.
Then, Mir sends a MirEvent([touch(id=1,state=pressed)]). In MirEvents, every single active touch
point must be listed in the event even if it didn't change at all in the meantime. So that's a bug.
But instead of crashing or forwarding the bogus event stream down to Qt, QtEventFeeder should attempt
to fix the situation by synthesizing a touch[id=0,state=released] to be send along with the
touch(id=1,state=pressed) it got. So that Qt receives a correct touch event stream.
*/
TEST_F(QtEventFeederTest, GenerateMissingTouchEnd)
{
setIrrelevantMockWindowSystemExpectations();
EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(0),
IsPressed()))),_)).Times(1);
auto ev1 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(123), 0);
mev::add_touch(*ev1, 0 /* touch ID */, mir_touch_action_down, mir_touch_tooltype_unknown,
10, 10, 10 /* x, y, pressure */,
1, 1, 10 /* touch major, minor, size */);
qtEventFeeder->dispatch(*ev1);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
setIrrelevantMockWindowSystemExpectations();
// There can be only one pressed or released touch per event
{
InSequence sequence;
EXPECT_CALL(*mockWindowSystem,
handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(0),IsReleased()))
),_)).Times(1);
EXPECT_CALL(*mockWindowSystem,
handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(1),IsPressed()))
),_)).Times(1);
}
auto ev2 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(125), 0);
mev::add_touch(*ev2, 1 /* touch ID */, mir_touch_action_down, mir_touch_tooltype_unknown,
20, 20, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
qtEventFeeder->dispatch(*ev2);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
}
TEST_F(QtEventFeederTest, GenerateMissingTouchEnd2)
{
setIrrelevantMockWindowSystemExpectations();
auto ev1 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(123), 0);
mev::add_touch(*ev1, 0 /* touch ID */, mir_touch_action_down, mir_touch_tooltype_unknown,
10, 10, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(0),
IsPressed()))),_)).Times(1);
qtEventFeeder->dispatch(*ev1);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
// ---
setIrrelevantMockWindowSystemExpectations();
auto ev2 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(124), 0);
mev::add_touch(*ev2, 0 /* touch ID */, mir_touch_action_change, mir_touch_tooltype_unknown,
10, 10, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
mev::add_touch(*ev2, 1 /* touch ID */, mir_touch_action_down, mir_touch_tooltype_unknown,
20, 20, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
EXPECT_CALL(*mockWindowSystem,
handleTouchEvent(_,_,AllOf(SizeIs(2),
Contains(AllOf(HasId(0), StateIsMoved())),
Contains(AllOf(HasId(1), IsPressed()))
),_)).Times(1);
qtEventFeeder->dispatch(*ev2);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
// ---
setIrrelevantMockWindowSystemExpectations();
// touch 0 disappeared and touch 2 got pressed
auto ev3 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(125), 0);
mev::add_touch(*ev3, 1 /* touch ID */, mir_touch_action_change, mir_touch_tooltype_unknown,
20, 20, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
mev::add_touch(*ev3, 2 /* touch ID */, mir_touch_action_down, mir_touch_tooltype_unknown,
30, 30, 10 /* x, y, pressure*/,
1, 1, 10 /* touch major, minor, size */);
// There can be only one pressed or released touch per event
{
InSequence sequence;
// first release touch 0
EXPECT_CALL(*mockWindowSystem,
handleTouchEvent(_,_,AllOf(SizeIs(2),
Contains(AllOf(HasId(0), IsReleased())),
Contains(AllOf(HasId(1), IsStationary()))
),_)).Times(1);
// then press touch 2
EXPECT_CALL(*mockWindowSystem,
handleTouchEvent(_,_,AllOf(SizeIs(2),
Contains(AllOf(HasId(1), StateIsMoved())),
Contains(AllOf(HasId(2), IsPressed()))
),_)).Times(1);
}
qtEventFeeder->dispatch(*ev3);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
}
TEST_F(QtEventFeederTest, PressSameTouchTwice)
{
setIrrelevantMockWindowSystemExpectations();
EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(0),
IsPressed()))),_)).Times(1);
auto ev1 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(123), 0);
mev::add_touch(*ev1, /* touch ID */ 0, mir_touch_action_down, mir_touch_tooltype_unknown,
10, 10, 10, 1, 1, 10);
qtEventFeeder->dispatch(*ev1);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
setIrrelevantMockWindowSystemExpectations();
EXPECT_CALL(*mockWindowSystem, handleTouchEvent(_,_,AllOf(SizeIs(1),
Contains(AllOf(HasId(0), StateIsMoved()))
),_)).Times(1);
auto ev2 = mev::make_event(MirInputDeviceId(), std::chrono::milliseconds(123), 0);
mev::add_touch(*ev2, /* touch ID */ 0, mir_touch_action_down, mir_touch_tooltype_unknown,
10, 10, 10, 1, 1, 10);
qtEventFeeder->dispatch(*ev2);
ASSERT_TRUE(Mock::VerifyAndClearExpectations(mockWindowSystem));
}
|
