aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2020-06-09 10:52:48 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2020-06-09 11:51:55 +0200
commit76d5ddebc281543294a330da3e56feea080581bb (patch)
tree5ec9b44edd2e0f9f3e6b3be1868f8490d6039f2c
parent88af089cb0419e1f1a27dc77e11f5513f9ddd8d0 (diff)
Fix leaking reference in PySide2 property getter
Remove Py_INCREF on result obtained from PyObject_CallObject() in getValue(PySideProperty*,*source). Change-Id: Ic070df29be0fd0eadcd37bc0210339205f957c8f Fixes: PYSIDE-1321 Reviewed-by: Christian Tismer <tismer@stackless.com>
-rw-r--r--sources/pyside2/libpyside/pyside.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/sources/pyside2/libpyside/pyside.cpp b/sources/pyside2/libpyside/pyside.cpp
index d22958398..e2b8708ce 100644
--- a/sources/pyside2/libpyside/pyside.cpp
+++ b/sources/pyside2/libpyside/pyside.cpp
@@ -328,7 +328,6 @@ PyObject *getMetaDataFromQObject(QObject *cppSelf, PyObject *self, PyObject *nam
Py_DECREF(attr);
if (!value)
return 0;
- Py_INCREF(value);
attr = value;
}