diff options
| author | Christian Tismer <tismer@stackless.com> | 2022-07-27 18:13:11 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-08-04 13:22:04 +0000 |
| commit | 2a17b2744cf22539119fbc06c46d383b8583525f (patch) | |
| tree | 23d7a5bea337d02444370096e4a6e971b81b197f | |
| parent | b4e84e29ffcced2dd977e01482c7f3d9adc8363b (diff) | |
build: Fix a weird build problem on macOS and other platforms
There was a long existing bug in the PySide build system that
had a weird effect on macOS:
* building PySide with Limited API and testing worked fine.
* building PySide without Limited API worked fine too, but gave
crashes when testing pysidetest. It appears that macos
duplicates a static Python build, one of them uninitialized.
After a month with no solution, a Linux build had problems, too,
but complained already in the build.
It was solved by passing `--enable-shared` to the Python build.
This `--enable-shared` solved the macOS problem as well.
Further analysis by Alexandru led to the suggestion that the
Python libraries in pysidetest are not needed at all, and by
removing them, the whole problem went away.
This is now confirmed on other platforms as well. The option
`--enable-shared` is no longer needed in any configuration.
The problem was caused by 22e359bc19daf19033332aa2d7bb9726c7f4be14
from 2020-02-18.
Task-number: PYSIDE-1735
Change-Id: I08b8628e75ef9c664be30200ae295cd2e6004370
Reviewed-by: Christian Tismer <tismer@stackless.com>
(cherry picked from commit 114de72f1f63999a08f698a0972cce3a7f33a372)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | sources/pyside6/tests/pysidetest/CMakeLists.txt | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/sources/pyside6/tests/pysidetest/CMakeLists.txt b/sources/pyside6/tests/pysidetest/CMakeLists.txt index 7640c2d63..ee2a295fe 100644 --- a/sources/pyside6/tests/pysidetest/CMakeLists.txt +++ b/sources/pyside6/tests/pysidetest/CMakeLists.txt @@ -117,16 +117,9 @@ if(WIN32) set_property(TARGET testbinding PROPERTY SUFFIX ".pyd") endif() -if(PYTHON_LIMITED_API) - set(TESTBINDING_PYTHON_LIBS ${PYTHON_LIMITED_LIBRARIES}) -else() - set(TESTBINDING_PYTHON_LIBS ${PYTHON_LIBRARIES}) -endif() - target_link_libraries(testbinding pysidetest pyside6 - ${TESTBINDING_PYTHON_LIBS} Shiboken6::libshiboken ${Qt${QT_MAJOR_VERSION}Core_LIBRARIES} ${Qt${QT_MAJOR_VERSION}Gui_LIBRARIES} |