diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-11-03 07:56:16 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-11-09 11:31:01 +0100 |
| commit | 849c460153681d3ea1fa17ff277c793d74f832d9 (patch) | |
| tree | 2d6422a58b6c5b8e610fd15f750825f6fbf6d084 | |
| parent | 3f2d6ca98bfef3e1c1126167ea323a0851fad8eb (diff) | |
build scripts: Fix warning about import order
Import Setuptools before Distutils, fixing:
distutils_patch.py:25: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.
Change-Id: Ibbc1a5cd1d348f6f44f7e80a3ba7e9a7341fae8e
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
(cherry picked from commit b70183a78ed7a478ae9f2af19bd84535a8e69320)
Reviewed-by: Christian Tismer <tismer@stackless.com>
| -rw-r--r-- | build_scripts/main.py | 14 | ||||
| -rw-r--r-- | build_scripts/setup_runner.py | 4 |
2 files changed, 8 insertions, 10 deletions
diff --git a/build_scripts/main.py b/build_scripts/main.py index 8fd6fd189..ea91ef751 100644 --- a/build_scripts/main.py +++ b/build_scripts/main.py @@ -236,6 +236,13 @@ except ImportError: from ez_setup import use_setuptools use_setuptools() +from setuptools import Extension +from setuptools.command.install import install as _install +from setuptools.command.install_lib import install_lib as _install_lib +from setuptools.command.bdist_egg import bdist_egg as _bdist_egg +from setuptools.command.develop import develop as _develop +from setuptools.command.build_py import build_py as _build_py + import distutils.log as log from distutils.errors import DistutilsSetupError from distutils.sysconfig import get_config_var @@ -246,13 +253,6 @@ from distutils.command.build_ext import build_ext as _build_ext from distutils.util import get_platform from distutils.cmd import Command -from setuptools import Extension -from setuptools.command.install import install as _install -from setuptools.command.install_lib import install_lib as _install_lib -from setuptools.command.bdist_egg import bdist_egg as _bdist_egg -from setuptools.command.develop import develop as _develop -from setuptools.command.build_py import build_py as _build_py - from .qtinfo import QtInfo from .utils import rmtree, detect_clang, copyfile, copydir, run_process_output, run_process from .utils import update_env_path, init_msvc_env, filter_match diff --git a/build_scripts/setup_runner.py b/build_scripts/setup_runner.py index 6b944c2c8..57c8fbd1f 100644 --- a/build_scripts/setup_runner.py +++ b/build_scripts/setup_runner.py @@ -41,6 +41,7 @@ import sys import os import textwrap +from setuptools import setup # Import setuptools before distutils import distutils.log as log from build_scripts.config import config @@ -49,9 +50,6 @@ from build_scripts.main import cmd_class_dict from build_scripts.options import ADDITIONAL_OPTIONS, OPTION from build_scripts.utils import run_process -from setuptools import setup - - class SetupRunner(object): def __init__(self, orig_argv): |