aboutsummaryrefslogtreecommitdiffstats
path: root/generator
diff options
context:
space:
mode:
authorRenato Araujo Oliveira Filho <renato.filho@openbossa.org>2011-01-13 15:04:03 -0300
committerHugo Parente Lima <hugo.pl@gmail.com>2012-03-08 16:12:53 -0300
commit3b747443bde5752277aa9791adbfc1d32868689b (patch)
tree46331deab4d066a8588504a0a4c9867a74615200 /generator
parent78e3c256ff6a154ce8068b3dd7bc551394d73422 (diff)
Used c++ pointer during the c++ class attribute get function.
Now all function get for class attribute return the internal memory of the c++ attribute. Reviewer: Hugo Parente <hugo.lima@openbossa.org> Luciano Wolf <luciano.wolf@openbossa.org>
Diffstat (limited to 'generator')
-rw-r--r--generator/cppgenerator.cpp34
1 files changed, 28 insertions, 6 deletions
diff --git a/generator/cppgenerator.cpp b/generator/cppgenerator.cpp
index 01f8a6d47..dcee8fd77 100644
--- a/generator/cppgenerator.cpp
+++ b/generator/cppgenerator.cpp
@@ -2711,18 +2711,40 @@ void CppGenerator::writeGetterFunction(QTextStream& s, const AbstractMetaField*
{
s << "static PyObject* " << cpythonGetterFunctionName(metaField) << "(PyObject* self, void*)" << endl;
s << '{' << endl;
- s << INDENT << "return ";
+ s << INDENT << "PyObject* val = ";
QString cppField;
+ AbstractMetaType *metaType = metaField->type();
+ // Force use of pointer to return internal variable memory
+ bool useReference = (!metaType->isConstant() &&
+ !metaType->isEnum() &&
+ !metaType->isPrimitive() &&
+ metaType->indirections() == 0);
+
#ifdef AVOID_PROTECTED_HACK
if (metaField->isProtected())
- cppField = QString("((%1*)%2)->%3()").arg(wrapperName(metaField->enclosingClass())).arg(cpythonWrapperCPtr(metaField->enclosingClass(), "self")).arg(protectedFieldGetterName(metaField));
+ cppField = QString("(%1(%2*)%3)->%4()")
+ .arg(useReference ? '&' : ' ')
+ .arg(wrapperName(metaField->enclosingClass()))
+ .arg(cpythonWrapperCPtr(metaField->enclosingClass(), "self"))
+ .arg(protectedFieldGetterName(metaField));
else
#endif
- cppField= QString("%1->%2").arg(cpythonWrapperCPtr(metaField->enclosingClass(), "self")).arg(metaField->name());
- writeToPythonConversion(s, metaField->type(), metaField->enclosingClass(), cppField);
- s << ';' << endl;
- s << '}' << endl;
+ cppField= QString("%1%2->%3")
+ .arg(useReference ? '&' : ' ')
+ .arg(cpythonWrapperCPtr(metaField->enclosingClass(), "self"))
+ .arg(metaField->name());
+
+ if (useReference) {
+ s << INDENT << "Shiboken::createWrapper(" << cppField << ");" << endl;
+ s << INDENT << "Shiboken::Object::releaseOwnership(val);" << endl;
+ } else {
+ writeToPythonConversion(s, metaField->type(), metaField->enclosingClass(), cppField);
+ s << ';' << endl;
+ }
+
+ s << INDENT << "return val;" << endl
+ << endl << '}' << endl;
}
void CppGenerator::writeSetterFunction(QTextStream& s, const AbstractMetaField* metaField)