Avoid read the property in the QObject constructor.

Create unit test to verify if the python property is setted during the constructor.

Reviewer: Hugo Parente <hugo.lima@openbossa.org>
          Luciano Wolf <luciano.wolf@openbossa.org>

1 files changed, 7 insertions, 5 deletions

diff --git a/libpyside/qproperty.cpp b/libpyside/qproperty.cpp
index b2d011e85..c4b728ac5 100644
--- a/libpyside/qproperty.cpp
+++ b/libpyside/qproperty.cpp
@@ -231,12 +231,14 @@ const char* qproperty_get_type(PyObject* self)
 
 PyObject* qproperty_get_object(PyObject* source, PyObject* name)
 {
-    if (PyObject_HasAttr(source, name)) {
-        PyObject* attr = PyObject_GenericGetAttr(source, name);
-        if (isQPropertyType(attr))
-            return attr;
+    PyObject* attr = PyObject_GenericGetAttr(source, name);
+    if (attr && isQPropertyType(attr))
+        return attr;
+
+    if (!attr)
+        PyErr_Clear(); //Clear possible error caused by PyObject_GenericGetAttr
+    else
         Py_DECREF(attr);
-    }
     return 0;
 }