diff options
author | Renato Filho <renato.filho@openbossa.org> | 2010-06-16 13:52:09 -0300 |
---|---|---|
committer | Renato Filho <renato.filho@openbossa.org> | 2010-06-17 15:34:34 -0300 |
commit | 83cf37f609ca3adb343be090054188dc254b9741 (patch) | |
tree | 7998ad2929a92f0d424c8166f70db1dcc40b716e /libpyside | |
parent | 4cca85f52585b17f53e26f81ca26504fe561e578 (diff) |
Create unit-test for signal with QObject.
Reviewer: Hugo Parente Lima <hugo.lima@openbossa.org>,
Luciano Wolf <luciano.wolf@openbossa.org>
Diffstat (limited to 'libpyside')
-rw-r--r-- | libpyside/qsignal.cpp | 8 | ||||
-rw-r--r-- | libpyside/signalmanager.cpp | 13 |
2 files changed, 16 insertions, 5 deletions
diff --git a/libpyside/qsignal.cpp b/libpyside/qsignal.cpp index 1edc13c04..43c02f1cd 100644 --- a/libpyside/qsignal.cpp +++ b/libpyside/qsignal.cpp @@ -246,7 +246,12 @@ char* signal_get_type_name(PyObject* type) if (PyType_Check(type)) { //tp_name return the full name Shiboken::AutoDecRef typeName(PyObject_GetAttrString(type, "__name__")); - return strdup(PyString_AS_STRING(typeName.object())); + char *aux = strdup(PyString_AS_STRING(typeName.object())); + if (Shiboken::TypeResolver::getType(aux) == Shiboken::TypeResolver::ObjectType) { + aux = reinterpret_cast<char*>(realloc(aux, strlen(aux) + 1)); + aux = strcat(aux, "*"); + } + return aux; } else if (PyString_Check(type)) { return strdup(PyString_AS_STRING(type)); } @@ -281,7 +286,6 @@ char* signal_parse_signature(PyObject *args) } } } - return signature; } diff --git a/libpyside/signalmanager.cpp b/libpyside/signalmanager.cpp index 7ac3f3067..6ea05c918 100644 --- a/libpyside/signalmanager.cpp +++ b/libpyside/signalmanager.cpp @@ -253,7 +253,12 @@ static bool emitNormalSignal(QObject* source, int signalIndex, const char* signa for (i = 0; i < argsGiven; ++i) { Shiboken::TypeResolver* typeResolver = Shiboken::TypeResolver::get(qPrintable(argTypes[i])); if (typeResolver) { - signalArgs[i+1] = typeResolver->toCpp(PySequence_Fast_GET_ITEM(sequence.object(), i)); + void *data = typeResolver->toCpp(PySequence_Fast_GET_ITEM(sequence.object(), i)); + if (Shiboken::TypeResolver::getType(qPrintable(argTypes[i])) == Shiboken::TypeResolver::ObjectType) { + signalArgs[i+1] = &data; + } else { + signalArgs[i+1] = data; + } } else { PyErr_Format(PyExc_TypeError, "Unknown type used to emit a signal: %s", qPrintable(argTypes[i])); break; @@ -289,7 +294,6 @@ bool SignalManager::emitSignal(QObject* source, const char* signal, PyObject* ar else return emitNormalSignal(source, signalIndex, signal, args, argTypes); } - qDebug() << "Signal" << signal << "not found, probably a typo or you are emitting a dynamic signal that has never been used in a connection until now."; return false; } @@ -316,7 +320,10 @@ int PySide::SignalManager::qt_metacall(QObject* object, QMetaObject::Call call, Shiboken::AutoDecRef preparedArgs(PyTuple_New(paramTypes.count())); for (int i = 0, max = paramTypes.count(); i < max; ++i) { - PyObject* arg = Shiboken::TypeResolver::get(paramTypes[i].constData())->toPython(args[i+1]); + void* data = args[i+1]; + const char* dataType = paramTypes[i].constData(); + + PyObject* arg = Shiboken::TypeResolver::get(dataType)->toPython(data); PyTuple_SET_ITEM(preparedArgs.object(), i, arg); } |