diff options
| author | Hugo Lima <hugo.lima@openbossa.org> | 2010-02-23 16:54:40 -0300 |
|---|---|---|
| committer | Hugo Lima <hugo.lima@openbossa.org> | 2010-02-23 16:54:40 -0300 |
| commit | 8b21935e055b2761cea73d2c5f9e2b23409ac3c2 (patch) | |
| tree | 55630f4f130bc4fb06809f8060cba9fa6d6570c6 /shibokengenerator.cpp | |
| parent | 1195a4e8cf7319f9bd4da248ff48e2cd0fa193bc (diff) | |
Pass QStrings by const references instead of by value.
Diffstat (limited to 'shibokengenerator.cpp')
| -rw-r--r-- | shibokengenerator.cpp | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/shibokengenerator.cpp b/shibokengenerator.cpp index 4de0e55de..048ea874a 100644 --- a/shibokengenerator.cpp +++ b/shibokengenerator.cpp @@ -336,7 +336,7 @@ void ShibokenGenerator::writeBaseConversion(QTextStream& s, const AbstractMetaTy } void ShibokenGenerator::writeToPythonConversion(QTextStream& s, const AbstractMetaType* type, - const AbstractMetaClass* context, QString argumentName) + const AbstractMetaClass* context, const QString& argumentName) { if (!type) return; @@ -349,7 +349,7 @@ void ShibokenGenerator::writeToPythonConversion(QTextStream& s, const AbstractMe } void ShibokenGenerator::writeToCppConversion(QTextStream& s, const AbstractMetaType* type, - const AbstractMetaClass* context, QString argumentName) + const AbstractMetaClass* context, const QString& argumentName) { writeBaseConversion(s, type, context); s << "toCpp(" << argumentName << ')'; @@ -475,7 +475,7 @@ QString ShibokenGenerator::cpythonOperatorFunctionName(const AbstractMetaFunctio + '_' + pythonOperatorFunctionName(func->originalName()); } -QString ShibokenGenerator::pythonPrimitiveTypeName(QString cppTypeName) +QString ShibokenGenerator::pythonPrimitiveTypeName(const QString& cppTypeName) { return ShibokenGenerator::m_pythonPrimitiveTypeName.value(cppTypeName, QString()); } @@ -1202,12 +1202,11 @@ QString ShibokenGenerator::getApiExportMacro() const return "SHIBOKEN_"+moduleName().toUpper()+"_API"; // a longer name to avoid name clashes } -QString ShibokenGenerator::getModuleHeaderFileName(QString modName) const +QString ShibokenGenerator::getModuleHeaderFileName(const QString& moduleName) const { - if (modName.isEmpty()) - modName = packageName(); - modName.replace(".", "_"); - return QString("%1_python.h").arg(modName.toLower()); + QString result = moduleName.isEmpty() ? packageName() : moduleName; + result.replace(".", "_"); + return QString("%1_python.h").arg(result.toLower()); } bool ShibokenGenerator::isCopyable(const AbstractMetaClass *metaClass) |