diff options
author | Cristian Maureira-Fredes <Cristian.Maureira-Fredes@qt.io> | 2020-09-04 10:58:09 +0200 |
---|---|---|
committer | Cristian Maureira-Fredes <Cristian.Maureira-Fredes@qt.io> | 2020-09-04 14:55:25 +0200 |
commit | 8d1fcdf94f2c368f7877f9e0cb2995e00f103e1a (patch) | |
tree | c79917b2e40b35fa7c8fe1385a8bbae8b2f06507 /sources/pyside2/PySide2 | |
parent | fedc289138bd912384e71a91e49ef9ee7b8a0fbb (diff) |
QDomElement: remove unnecesary setAttribute overloads
Removing all the different overloads that don't make much
sense in Python land, leaving only one for integers (qlonglong),
and one for floats (double), since in Python those are the general
primitive types to handle, and having a proper transformation
for uint, qulonglong, float, etc, is not really mandatory.
Fixes: PYSIDE-1372
Change-Id: Iba2e3d560dd971e3ecd0146bd5e2ec47f09c16e6
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'sources/pyside2/PySide2')
-rw-r--r-- | sources/pyside2/PySide2/QtXml/typesystem_xml.xml | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/sources/pyside2/PySide2/QtXml/typesystem_xml.xml b/sources/pyside2/PySide2/QtXml/typesystem_xml.xml index e1750fb80..96d12ea4e 100644 --- a/sources/pyside2/PySide2/QtXml/typesystem_xml.xml +++ b/sources/pyside2/PySide2/QtXml/typesystem_xml.xml @@ -231,7 +231,20 @@ <object-type name="QXmlNamespaceSupport"/> - <value-type name="QDomElement"/> + <value-type name="QDomElement"> + <!-- PYSIDE-1372 + We will leave only one for int, and one for float since Python + doesn't have other variations on the primitive types. + Only 'qlonglong' and 'double' will be available from the Qt API. + TODO: This will require a better review of the shiboken primitive + types converters, since this situation might happen on + different signatures. + --> + <modify-function signature="setAttribute(const QString&, uint)" remove="all"/> + <modify-function signature="setAttribute(const QString&, float)" remove="all"/> + <modify-function signature="setAttribute(const QString&, int)" remove="all"/> + <modify-function signature="setAttribute(const QString&, qulonglong)" remove="all"/> + </value-type> <object-type name="QXmlContentHandler"> <modify-function signature="setDocumentLocator(QXmlLocator*)"> |