libpyside: Fix clang-tidy warnings about class definitions

- Add override
- Use = default for trivial constructors/destructors
- Add Q_DISABLE_COPY where applicable
- Use member initialization and remove constructors from simple structs
- Use explicit where applicable (which requires adapting code snippets
  constructing a QVariant from PyObjectWrapper)
- Fix some parameter to take a const ref or pass by value
  and use std::move in constructors

Change-Id: I5e0d2c4ef92d20397a7daba2f8a64b507e678510
Reviewed-by: Christian Tismer <tismer@stackless.com>

1 files changed, 4 insertions, 3 deletions

diff --git a/sources/pyside2/libpyside/pyside.cpp b/sources/pyside2/libpyside/pyside.cpp
index 07d93bded..b70743cee 100644
--- a/sources/pyside2/libpyside/pyside.cpp
+++ b/sources/pyside2/libpyside/pyside.cpp
@@ -187,7 +187,8 @@ void destroyQCoreApplication()
 }
 
 struct TypeUserData {
-    TypeUserData(PyTypeObject* type, const QMetaObject* metaobject) : mo(type, metaobject) {}
+    explicit TypeUserData(PyTypeObject* type,  const QMetaObject* metaobject, std::size_t size) :
+        mo(type, metaobject), cppObjSize(size) {}
     DynamicQMetaObject mo;
     std::size_t cppObjSize;
 };
@@ -202,8 +203,8 @@ std::size_t getSizeOfQObject(SbkObjectType* type)
 void initDynamicMetaObject(SbkObjectType* type, const QMetaObject* base, std::size_t cppObjSize)
 {
     //create DynamicMetaObject based on python type
-    TypeUserData* userData = new TypeUserData(reinterpret_cast<PyTypeObject*>(type), base);
-    userData->cppObjSize = cppObjSize;
+    auto userData =
+        new TypeUserData(reinterpret_cast<PyTypeObject*>(type), base, cppObjSize);
     userData->mo.update();
     Shiboken::ObjectType::setTypeUserData(type, userData, Shiboken::callCppDestructor<TypeUserData>);