diff options
| author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-30 13:23:31 +0200 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2018-08-30 16:36:39 +0000 |
| commit | 83f09c51f76f17255b34e72a5a3c9b7b325e7aae (patch) | |
| tree | 0f8f26e3361f3759bde46f7f5faa8a5d7ab2cf88 /sources/pyside2/libpyside/pysideslot.cpp | |
| parent | 08af692e40cb178ad59af2ed7b7b8928c0ac2ff6 (diff) | |
libpyside: Fix remaining clang-tidy warnings
- Remove else after return/continue/break; unindent code
or simplify return conditions
- Use isEmpty() to check for empty containers
- Fix C-style casts
- Pass std::size_t by value instead of const ref
Change-Id: Ic997d7c39720c1cd3698c4d750e9cfc1f1654788
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside2/libpyside/pysideslot.cpp')
| -rw-r--r-- | sources/pyside2/libpyside/pysideslot.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sources/pyside2/libpyside/pysideslot.cpp b/sources/pyside2/libpyside/pysideslot.cpp index fddff54fa..817857053 100644 --- a/sources/pyside2/libpyside/pysideslot.cpp +++ b/sources/pyside2/libpyside/pysideslot.cpp @@ -96,8 +96,10 @@ int slotTpInit(PyObject *self, PyObject *args, PyObject *kw) if (emptyTuple == 0) emptyTuple = PyTuple_New(0); - if (!PyArg_ParseTupleAndKeywords(emptyTuple, kw, "|sO:QtCore." SLOT_DEC_NAME, (char**) kwlist, &argName, &argResult)) + if (!PyArg_ParseTupleAndKeywords(emptyTuple, kw, "|sO:QtCore." SLOT_DEC_NAME, + const_cast<char**>(kwlist), &argName, &argResult)) { return 0; + } PySideSlot *data = reinterpret_cast<PySideSlot*>(self); for(Py_ssize_t i = 0, i_max = PyTuple_Size(args); i < i_max; i++) { |