diff options
author | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-02-13 14:45:46 +0100 |
---|---|---|
committer | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-03-02 16:00:23 +0000 |
commit | 095fd339a238fe2ad5ec6080119882436d95fde3 (patch) | |
tree | 2cf8db3a692b4a622194168282d0ef2ce3f996b2 /sources/pyside2/tests/QtTest | |
parent | e9e157032ab383c894c38517a047860232e45482 (diff) |
Check slot-signal association when connecting
When connecting a signal with a slot there is a process
to associate the proper signal signature, but the slot
signature was not verified.
This missing verification step lead to wrongly associate
the slots and the signal signatures, for example:
def on_clicked(checked=True):
...
QGroupBox.clicked.connect(on_clicked)
will wrongly connect the slot "on_clicked" with the
signal "clicked()" (without any argument),
when the proper signal is "clicked(bool)".
This can be solved by manually specifying the arguments:
QGroupBox.clicked[bool].connect(self.clicked)
We can add an additional verification step
to associate the proper signal if the slot has
a certain number of arguments.
There is an existing test that checks the compatibility
of this change with all the ways to connect
signals and slots.
A few additional cases were added.
Task-number: PYSIDE-104
Change-Id: Ic5b06fa3bb91903f7d506e0e2c52a6f7d3dc4570
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources/pyside2/tests/QtTest')
0 files changed, 0 insertions, 0 deletions