diff options
author | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-04-10 16:43:31 +0200 |
---|---|---|
committer | Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> | 2018-05-01 21:30:01 +0000 |
commit | 2159f4fdf5e0497c0df96ab200753761e3668700 (patch) | |
tree | 0b79c1e3d2ead7135ff4568d801c97fddc56a538 /sources/pyside2/tests/QtWidgets/bug_714.py | |
parent | d2fa0f63f08f5cca57be306b9569cb9a76af7cea (diff) |
Avoid set parent for QLabel.pixmap()
Setting owner as default to not allow Python to create a copy
of the QPixmap associated with the QLabel.
The C++ object pointer is acquired through the pixmap() method.
A test case was included.
Task-number: PYSIDE-150
Change-Id: Ie6975c39cbf49a59ebd478db0e1a0c30fc14864a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'sources/pyside2/tests/QtWidgets/bug_714.py')
-rw-r--r-- | sources/pyside2/tests/QtWidgets/bug_714.py | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/sources/pyside2/tests/QtWidgets/bug_714.py b/sources/pyside2/tests/QtWidgets/bug_714.py index 93dee6630..35d4f6d62 100644 --- a/sources/pyside2/tests/QtWidgets/bug_714.py +++ b/sources/pyside2/tests/QtWidgets/bug_714.py @@ -38,8 +38,12 @@ class TestLabelPixmap(unittest.TestCase): l.setPixmap(p) # doesn't increment pixmap ref because this makes a copy self.assertEqual(sys.getrefcount(p), 2) - p = l.pixmap() # this increment the reference because this is an internal pointer - self.assertEqual(sys.getrefcount(p), 3) + p = l.pixmap() + # this used to increment the reference because this is + # an internal pointer, but not anymore since we don't create + # a copy + # self.assertEqual(sys.getrefcount(p), 3) + self.assertEqual(sys.getrefcount(p), 2) p2 = l.pixmap() self.assertEqual(p, p2) |