shiboken: replace first()/last() by constFirst/constLast()

Fix clazy warnings about possibly detaching containers.

Change-Id: I3c3a229de5e0c71f17c1f26273e1b0be3b0d7e81
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>

1 files changed, 3 insertions, 4 deletions

diff --git a/sources/shiboken2/generator/main.cpp b/sources/shiboken2/generator/main.cpp
index b22919981..774775fb0 100644
--- a/sources/shiboken2/generator/main.cpp
+++ b/sources/shiboken2/generator/main.cpp
@@ -218,7 +218,7 @@ static QMap<QString, QString> getInitializedArguments()
 {
     QMap<QString, QString> args;
     QStringList arguments = QCoreApplication::arguments();
-    QString appName = arguments.first();
+    QString appName = arguments.constFirst();
     arguments.removeFirst();
 
     QString projectFileName;
@@ -502,9 +502,8 @@ int main(int argc, char *argv[])
             QStringList parts = fullVersion.split(QLatin1Char(','));
             QString package;
             QString version;
-            // avoid constFirst to stay Qt 5.5 compatible
-            package = parts.count() == 1 ? QLatin1String("*") : parts.first();
-            version = parts.last();
+            package = parts.count() == 1 ? QLatin1String("*") : parts.constFirst();
+            version = parts.constLast();
             if (!extractor.setApiVersion(package, version)) {
                 errorPrint(msgInvalidVersion(package, version));
                 return EXIT_FAILURE;