diff options
author | Christian Tismer <tismer@stackless.com> | 2017-04-28 18:55:08 +0200 |
---|---|---|
committer | Christian Tismer <tismer@stackless.com> | 2017-05-09 08:33:51 +0000 |
commit | c088cec468d6d908adeaeceec46022d10b55fb75 (patch) | |
tree | b14038747689f101961fbae1e270763f73b59cc2 /sources/shiboken2/libshiboken/shiboken.h | |
parent | 388d512b0903455236ec1057e8213204000f5b5d (diff) |
Fix headergenerator to build under C++11
For a long time, headergenerator.cpp did only generate destructors,
when the following condition was set:
if (!avoidProtectedHack() || !metaClass->hasPrivateDestructor()) {
// generate destructor
}
The condition does not work for C++11.
When trying to remove the protected hack, I remembered that
I used an ugly CMake trick to make VS 2015 work. This hack
provided exactly the missing destructors.
I tried very hard to make this hack into a patch for Linux and
macOS, too. Unfortunately, when built without the protected hack,
Clang enforces a destructor declaration, but then the linker reports
an unresolved symbol. I have found no way to circumvent this.
Conclusion: Unless we find a way to make Clang work correctly,
we have to leave the protected hack as-is on macOS.
But then, the whole effort of hack removal makes no more sense.
Fortunately, the ugly work-around on Windows is gone, now.
So this change involves shiboken and PySide, and probably the one
will not work without the other.
Task-number: PYSIDE-504
Change-Id: I92b372c15fd2a4280a249de4c099eeb1f18fedd3
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Diffstat (limited to 'sources/shiboken2/libshiboken/shiboken.h')
0 files changed, 0 insertions, 0 deletions