diff options
| author | Christian Tismer <tismer@stackless.com> | 2021-04-20 17:46:31 +0200 |
|---|---|---|
| committer | Christian Tismer <tismer@stackless.com> | 2021-04-22 10:55:03 +0200 |
| commit | b833d09c0a83d54899bbdf36367c15fb820d63c6 (patch) | |
| tree | 1e966dbd6e4d1689a8bcba21de1d3d155484d97a /sources | |
| parent | 871e9e6827d4e987546631befb62b833dd46af23 (diff) | |
signature: Refine the decision heuristics of result tuples
Result tuples do not (yet) get information from XML.
Instead, they fetch their info solely from the embedded
signature strings and information encoded in mapping.py .
When a variable is determined as a result variable, it is
removed from the arg list and normally appended to the
return tuple.
It turned out that a special rule is needed:
A variable that comes first in the variable list should
also be first in the result tuple.
This heuristics should be replaced by more introspection.
Right now, this suffices as a working fix.
Fixes: PYSIDE-1409
Change-Id: Ib65682439e2f678380e0f58a42a36506d0766ddf
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
(cherry picked from commit 3506158551488788450498f9b4ffe86375172fea)
Reviewed-by: Christian Tismer <tismer@stackless.com>
Diffstat (limited to 'sources')
| -rw-r--r-- | sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/parser.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/parser.py b/sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/parser.py index 689861d35..ec77208c8 100644 --- a/sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/parser.py +++ b/sources/shiboken2/shibokenmodule/files.dir/shibokensupport/signature/parser.py @@ -370,7 +370,9 @@ def fix_variables(props, line): if not isinstance(ann, ResultVariable): continue # We move the variable to the end and remove it. - retvars.append(ann.type) + # PYSIDE-1409: If the variable was the first arg, we move it to the front. + # XXX This algorithm should probably be replaced by more introspection. + retvars.insert(0 if idx == 0 else len(retvars), ann.type) deletions.append(idx) del annos[name] for idx in reversed(deletions): |