Fixed wrong overload decisor generated code.

The decisor must check for the number of arguments before calling
Converter::isConvertible method, to avoid passing NULL pointers to it.
Unit tests were added.

Reviewed by Luciano Wolf <luciano.wolf@openbossa.org>
Reviewed by Renato Araújo <renato.filho@openbossa.org>

2 files changed, 35 insertions, 0 deletions

diff --git a/tests/libsample/samplenamespace.cpp b/tests/libsample/samplenamespace.cpp
index 7ad200830..159b19f0b 100644
--- a/tests/libsample/samplenamespace.cpp
+++ b/tests/libsample/samplenamespace.cpp
@@ -93,5 +93,25 @@ enumItemAsDefaultValueToIntArgument(int value)
     return value;
 }
 
+void
+forceDecisorSideA(ObjectType* object)
+{
+}
+
+void
+forceDecisorSideA(const Point& pt, const Str& text, ObjectType* object)
+{
+}
+
+void
+forceDecisorSideB(int a, ObjectType* object)
+{
+}
+
+void
+forceDecisorSideB(int a, const Point& pt, const Str& text, ObjectType* object)
+{
+}
+
 } // namespace SampleNamespace
 
diff --git a/tests/libsample/samplenamespace.h b/tests/libsample/samplenamespace.h
index e43a92f41..0456c56ef 100644
--- a/tests/libsample/samplenamespace.h
+++ b/tests/libsample/samplenamespace.h
@@ -36,6 +36,10 @@
 #define SAMPLENAMESPACE_H
 
 #include "libsamplemacros.h"
+#include "str.h"
+#include "point.h"
+
+class ObjectType;
 
 namespace SampleNamespace
 {
@@ -97,6 +101,17 @@ public:
     OkThisIsRecursiveEnough* methodReturningTypeFromParentScope() { return 0; }
 };
 
+// The combination of the following two overloaded methods could trigger a
+// problematic behaviour on the overload decisor, if it isn't working properly.
+LIBSAMPLE_API void forceDecisorSideA(ObjectType* object = 0);
+LIBSAMPLE_API void forceDecisorSideA(const Point& pt, const Str& text, ObjectType* object = 0);
+
+// The combination of the following two overloaded methods could trigger a
+// problematic behaviour on the overload decisor, if it isn't working properly.
+// This is a variation of forceDecisorSideB.
+LIBSAMPLE_API void forceDecisorSideB(int a, ObjectType* object = 0);
+LIBSAMPLE_API void forceDecisorSideB(int a, const Point& pt, const Str& text, ObjectType* object = 0);
+
 } // namespace SampleNamespace
 
 #endif // SAMPLENAMESPACE_H