diff options
| -rw-r--r-- | build_scripts/utils.py | 13 | ||||
| -rw-r--r-- | coin_build_instructions.py | 10 | ||||
| -rw-r--r-- | coin_test_instructions.py | 8 |
3 files changed, 17 insertions, 14 deletions
diff --git a/build_scripts/utils.py b/build_scripts/utils.py index cca93d09f..f535db636 100644 --- a/build_scripts/utils.py +++ b/build_scripts/utils.py @@ -1117,3 +1117,16 @@ def run_instruction(instruction, error): if result != 0: print("ERROR : " + error) exit(result) + +def acceptCITestConfiguration(hostOS, hostOSVer, targetArch, compiler): + # Disable unsupported CI configs for now + # NOTE: String must match with QT CI's storagesturct thrift + if hostOSVer in ["WinRT_10"]: + print("Disabled " + hostOSVer + " from Coin configuration") + return False + # With 5.11 CI will create two sets of release binaries, one with msvc 2015 and one with msvc 2017 + # we shouldn't release the 2015 version. BUT, 32 bit build is done only on msvc 2015... + if compiler in ["MSVC2015"] and targetArch in ["X86_64"]: + print("Disabled " + compiler + " to " + targetArch + " from Coin configuration") + return False + return True diff --git a/coin_build_instructions.py b/coin_build_instructions.py index f9f8d4d17..82841a320 100644 --- a/coin_build_instructions.py +++ b/coin_build_instructions.py @@ -43,6 +43,7 @@ from build_scripts.utils import get_qtci_virtualEnv from build_scripts.utils import run_instruction from build_scripts.utils import rmtree from build_scripts.utils import get_python_dict +from build_scripts.utils import acceptCITestConfiguration import os # Values must match COIN thrift @@ -121,14 +122,7 @@ def call_setup(python_ver): run_instruction(cmd, "Failed to run setup.py") def run_build_instructions(): - # Disable unsupported configs for now - if CI_HOST_OS_VER in ["WinRT_10"]: - print("Disabled " + CI_HOST_OS_VER + " from Coin configuration") - exit() - # With 5.11 CI will create two sets of release binaries, one with msvc 2015 and one with msvc 2017 - # we shouldn't release the 2015 version. BUT, 32 bit build is done only on msvc 2015... - if CI_COMPILER in ["MSVC2015"] and CI_TARGET_ARCH in ["X86_64"]: - print("Disabled " + CI_HOST_OS_VER + " from Coin configuration") + if not acceptCITestConfiguration(CI_HOST_OS, CI_HOST_OS_VER, CI_TARGET_ARCH, CI_COMPILER): exit() # Uses default python, hopefully we have python2 installed on all hosts diff --git a/coin_test_instructions.py b/coin_test_instructions.py index 350e33b0d..e90316784 100644 --- a/coin_test_instructions.py +++ b/coin_test_instructions.py @@ -42,6 +42,7 @@ from build_scripts.utils import install_pip_dependencies from build_scripts.utils import get_qtci_virtualEnv from build_scripts.utils import run_instruction from build_scripts.utils import rmtree +from build_scripts.utils import acceptCITestConfiguration import os # Values must match COIN thrift @@ -72,12 +73,7 @@ def call_testrunner(python_ver, buildnro): run_instruction(cmd, "Failed to run testrunner.py") def run_test_instructions(): - # Disable unsupported configs for now - if CI_HOST_OS_VER in ["WinRT_10"]: - print("Disabled " + CI_HOST_OS_VER + " from Coin configuration") - exit() - if CI_COMPILER in ["MSVC2015"] and CI_TARGET_ARCH in ["X86_64"]: - print("Disabled " + CI_HOST_OS_VER + " from Coin configuration") + if not acceptCITestConfiguration(CI_HOST_OS, CI_HOST_OS_VER, CI_TARGET_ARCH, CI_COMPILER): exit() os.chdir(CI_ENV_AGENT_DIR) |