| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I663e75d6a10c92aea9798e174e07dead45a21a59
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
| |
Change-Id: I7d840367d9a733d925bbfeb78a0ba0c9c076e6c0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
qApp should stay almost as it is with only two cosmetic changes:
When qApp's return value has Type(Py_None), the value now reports
"noApp" instead of "None".
Also the feature of "del __builtins__.qApp" is replaced by function
qApp.shutdown() . This makes things easier to explain and avoids
refcounting hacks.
The embedding problem (Falkon browser) was too complicated.
We finally solved it by disabling qApp in embedded mode.
Change-Id: I0d99661137130684823aa3d1978b494d8ab08e59
Fixes: PYSIDE-1158
Fixes: PYSIDE-1178
Fixes: PYSIDE-1135
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I70df7a265fd98ee9527909fc2e4e7bd1caacac98
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
| |
Change-Id: I74dd1dd6fbf1ad89c0d8e51dbaa0c19dcf55755b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
| |
Change-Id: I6ba4ae9fe6a9bfe669b76a23f27556b1f3c59eb4
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
|
|
|
|
|
|
|
|
| |
The goal of this file is to provide an example for signals being
emitted from one thread to another.
Task-number: PYSIDE-841
Change-Id: If494fbfef6d8c46b37d5b750163c909bc6c55c7a
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While the example works correctly as is, if one takes the StarEditor
class alone, it will fail to work as it uses a starRating attribute that
is available in the example only because of the call to setEditorData
by the StarDelegate class.
This patch fixes that as well makes use of the append overload of
QPolygonF taking a list of point to simplify the code a bit.
Change-Id: Id8132fa86f5668645f48c62377dac65f707c968b
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I97d7251b0d9ec024ce069f6475d7bc6be0d9d362
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
| |
Change-Id: Ibcefb190f5ea50b7c8575cd03b9e0f69b3a170b6
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Just before registering the signal to the meta-object,
the signalName was overwritten instead of checking if it had
some content.
Fixes: PYSIDE-1192
Change-Id: I5fc85bf22ae08bce6969b9381662288a99aee616
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
| |
Designer is not statically compiled, so we need to add
a RUNPATH to use the Qt libraries we ship with the wheel.
Change-Id: I715fcd852b63da99104198be2a4587b042a1eab7
Fixes: PYSIDE-1165
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
| |
Change-Id: I364ab18fede462ac9e6b5a318a29e5244e2f9156
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Shiboken macro only handles AttributeError
but when 'machinery' is not found inside 'importlib'
that case also needs to be handle by the except clause.
Adding ImportError will allow us to get access to the
Python suffixes that we need to build.
Additionally, some old versions of Python (2.7.14) require
an "archive_root" parameter on the 'wheel.pep425tags.get_supported'
function, which is not required in new versions (2.7.16, and 3+).
Change-Id: Icc6e7d1e9384ea01eec9281586f7ca988e3eb649
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Since it's a virtual method, we need to specify
that the native counterpart of the method will live
in C++, and in the target scope it will live in Python.
Fixes: PYSIDE-1207
Change-Id: I5b9072380eed17270affa39c5976dc6b1fe293ff
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed the color and the padding on the 'pre'
elements of the docs.
Additionally increased the line-height globally to 1.4
to make the reading easy.
Fixes: PYSIDE-1201
Change-Id: I292d4e6da616ecb84a923444b99ad28a28d6cc5d
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The doc parameter was being freed causing a segmentation fault,
according to the implementation of the parse function,
it's not necessary to free.
Fixes: PYSIDE-1205
Change-Id: I5850e7feaf354b27cc4496dc83be214d1729a048
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Prototypically use it for QMessageLogContext, allowing to elegantly
build for Qt from version 5.12..now using a single type system file.
Fixes: PYSIDE-1191
Change-Id: Iaa7bdc10c7129d84c54e85a09a1c802a409708f9
Reviewed-by: Christian Tismer <tismer@stackless.com>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
| |
Setting the page margin used for comparing tuples requires
a PDF printer. Ensure PDF format if no such printer can be found.
Change-Id: Ie8509d4a336392cb711e210842664e238c487444
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
| |
Compare integers using ==, fixing:
schema.py:203: SyntaxWarning: "is" with a literal. Did you mean "=="?(
Change-Id: Id94c454d4695bc3b0f89bf6b5301066d722b5e33
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
| |
Close the pipe obtained by POpen, fixing:
build_scripts\main.py:1185: ResourceWarning: unclosed file <_io.TextIOWrapper name=3 encoding='cp1252'>
out = run_process_output(cmake_cmd)
Change-Id: I5de0391003b40119758d93712d8178694e7fc14b
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I9cac73af695ecb123bc0e0b6ce35a10ee1026ea2
Reviewed-by: Christian Tismer <tismer@stackless.com>
|
|
|
|
|
|
|
|
|
| |
Qt5 5.14 is currently broken from Qt For Python point of view,
so we should verify Qt For Python against 5.14.1. This patch
should be reverted once Qt branches are fixed.
Change-Id: I8a0249284665381decc42f94faab6d8e9650f8bb
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I85216bcfc23161b832ecb675ea58f33e67004fe9
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
| |
Change-Id: Iba52405551440659d60b11b3dfb9078d6066cec6
Reviewed-by: Christian Tismer <tismer@stackless.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This trivial patch fixes an omission that has not been caught
in earlier versions:
PyObject_INIT
must be replaced by
PyObject_Init
I think this change came by chance and was not the primary intent
of the authors. Otherwise they would have made sure that the
PyObject_INIT macro does not even exist when the Limited API
is enabled.
Change-Id: Iee8127dd398f1ec0997b9a629c5c48076137cecf
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the class reference RSTs, the label entry must appear at first
before the current module entry. In addition, there must be at
least two empty lines before the page title. Otherwise, the
module's index page drops out of the toctree, resulting in
incomplete navigation breadcrumb.
Change-Id: I65a35b0bb9f2946fb5d45b1d1b8a453c20745e79
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The index adds all the class reference docs to the toctree
so we don't need to include everything under the module
directory.
Change-Id: I6ef20914a63a1f246b06b2725435a4fc42deaf9b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
|
|
|
|
| |
Change-Id: If2d96afbf93f153fb1b8e79f150a934620899d18
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
qApp has special treatment for the embedded case where some
Q*Application instance might exist before initialization happens.
In order to get these cases right, it was necessary to try to import
all three modules in question and do the initialization with the highest
existing module index.
Change-Id: Ifd27129ce166dee20e9424b1ee04a0d66cba79cc
Fixes: PYSIDE-1164
Task-number: PYSIDE-1135
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The qApp machinery works great with Python.
When using embedding, things are different because there
is no longer a wrapper layer.
Unfortunately, many extension modules use C++ to derive a
QApplication class.
This has the side effect that when a foreign C++ module gets
imported, the qApp machinery does not see it as it would
in Python.
Instead of a complex analysis, we always make sure that QtCore
is imported. It will report the right instance, anyway.
This change could not easily be tested.
It was confirmed as a solution by Antonio Rojas.
Change-Id: Ie9c56ac75e6c0ae3ace615dfc26c6d218ff4efea
Fixes: PYSIDE-1135
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
| |
We were missing QTEST_ENVIRONMENT variable which is used to indicate
that test is ran in Qt CI environment.
Change-Id: I4dd1e54117bfd5d0fa9368a8c2638ebc0257eb72
Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the QTEST_ENVIRONMENT variable was no longer set,
a number of crucial checks were not performed.
One side effect are the two new keys which were missing in the registry.
Additionally, the registry is missing very many entries on macOS, and I
have no idea what the reason is. This could be an effect of the
macOS 10.15.1 version or of my maybe outdated Qt 5.14.0 version.
The registry files from 2019-10-31 have all entries. If I build
that version from 2019-10-31 and test it, I get the same missing keys.
Therefore, I doubt my results quite a bit!
To verify this, we simply check this change in, together with
https://codereview.qt-project.org/c/pyside/pyside-setup/+/284809
If that works, then I have a serious bug somewhere, but we know then
that the harm of that CI bug was a minimum. Fingers crossed!!
Change-Id: I25555d60d6911fca6de67110c35dff8d23c2fd8a
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The generator subproject would still add the qtdocgenerator
source file even if neither QtXmlPatterns nor libxml/libxslt2
were found, causing link errors.
This is since the value of DISABLE_DOCSTRINGS was not propagated
up from the ApiExtractor subproject. Set it to the parent scope from
there as well.
Change-Id: If8dc7b0437ef8a8c1e71d822328bcc3809252b57
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: Ib8a0571cfecd0d0a938718f385e3b89d05ca2219
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
These examples will be used at the QtWS2019:
- Matplotlib: Widget interacting with a 3D plot
- OpenCV: Webcam pattern detection
- Scikit Image: Image filters
An About Qt section was added to all examples.
Change-Id: I14da69c9b5ecdc8409bcdb335135a8b1fa763bb1
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
| |
The content for this lived on the wiki till now.
Change-Id: I3e6a2cb7f97ab7021621b7c687299a3199134bb5
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a final optimization to the Py_TPFLAGS_METHOD_DESCRIPTOR
fix. Instead of keeping the mro method alive, we are caching it's type only,
because that is what we need to patch.
Another effort to solve this problem completely has failed, again.
This solution is good enough and has no time penalty.
Task-number: PYSIDE-939
Change-Id: I98c165f9cd704b0f6ce55750189d6bda9a811f70
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The TOC groups the classes alphabetically, ignoring the 'Q'
prefix at the beginning. It did not consider classes without
the 'Q' prefix, such as Signal and Slot in the QtCore module.
The else block should handle that as well now.
Change-Id: I0fc22ba86650299de924d22c970d6fe6e31567c3
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
| |
The check in find_error_like_snippets was incorrect, and thus never
showed any snippets.
Change-Id: Ie8d487b071e73c6f4a1352e9b10e616694b2e237
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
| |
Change-Id: Ibc5171cf94ef819cf7926b899b83cc9de3037d07
Reviewed-by: Christian Tismer <tismer@stackless.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
| |
Also ensured that all the doc entities are in the
toctree so that the navigation breadcrumb is
generated.
Change-Id: If993cca4c7e91723fa373d3453196bcfee9f3ffa
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I456dbb729992146ca3d2320d0d2416d9d3b41339
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This change uses the fact that our workaround to temporarily remove
the Py_TPFLAGS_METHOD_DESCRIPTOR flag uses the "mro" function
of PyType_Type, which never will change.
Therefore, the static keyword makes sure that this function lookup
happens only once.
Change-Id: I44b74556da1fac2596c81339af30cb66218276e2
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
|
|
|
|
|
|
|
|
|
| |
After Python 3.8 works with PySide, we can remove the restriction
to Python 3.7 from "python_requires".
Change-Id: I5be5364cda14c38aabc2bf579165efbb614969e0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes some refcounting problems with Python 3.8 .
One incompatible change was announced in the what's new
document, but actually there were two more problems which
were not explicitly mentioned but took much time to sort out.
The patch is compatible with the limited API changes
(tested with debug build and API error disabled).
It is also independent of the Python version which is
full Limited API support.
For more info, see the documentation mentioned below.
The flag error is circumvented now! We either find a better
solution or leave it as it is. For now this is ok.
Fixes: PYSIDE-939
Change-Id: Iff4a9816857a6ebe86efd4b654d8921e4e464939
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
| |
Change-Id: I11651033783052591f38cd8eb02ec47719c91dbf
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we are importing * from the options.py file,
which is a problem for the linters to discover if we are properly
using the options of the file.
Having a dictionary provides also a better way of access these options,
and it is more clean than having one variable per each option.
Change-Id: Ie70bd88665357b85e2842c5df269857504ecccdf
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- New structure for the landing page,
- Some rst were renamed to the new structure,
- New sections "Videos", "Examples" and "Getting Started" were created,
- Information from the wiki was used to create the Getting Started
sections,
- FAQ section was removed,
- Removing pyhtml2devhelp.py since it is unused,
- The new CSS modifications were copied over the Shiboken2 directory.
Task-number: PYSIDE-1067
Change-Id: I1ba53cd0030d6d02449fecdfea70efb49421ad3b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Kavindra Palaraja <kpalaraja@luxoft.com>
|
|
|
|
|
|
| |
Change-Id: I32fcdaa2df6a4bed4f3263875ab1ad272ad8ff8c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io>
|