| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PySide2/QtTest/typesystem_test.xml
2. Also fixed typo: Qt5Webkit -> Qt5WebKit
3. fixed global.h.in (@Qt5WebEngine_FOUND@ should be @Qt5WebEngineWidgets_FOUND@)
4. And fixed a couple of crash (more condition check).
`Scanning dependencies of target QtTest
[ 82%] Building CXX object PySide2/QtTest/CMakeFiles/QtTest.dir/PySide2/QtTest/qtest_pysideqtoucheventsequence_wrapper.cpp.o
[ 82%] Building CXX object PySide2/QtTest/CMakeFiles/QtTest.dir/PySide2/QtTest/qtest_wrapper.cpp.o
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:3836:40: error: expected ';' after top
level declarator
static PyObject* Sbk_QTestFunc_toString(PyObject* self, PyObject* pyArg)
^
;
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:4120:7: error: unexpected namespace name
'QTest': expected expression
::QTest* cppSelf = 0;
^
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:4120:14: error: use of undeclared
identifier 'cppSelf'
::QTest* cppSelf = 0;
^
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:4121:16: error: use of undeclared
identifier 'cppSelf'
SBK_UNUSED(cppSelf)
^
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_install/py2.7-qt5.6.0-64bit-release/include/shiboken2/helper.h:31:31: note: expanded from macro 'SBK_UNUSED'
#define SBK_UNUSED(x) (void)x;
^
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:4124:5: error: use of undeclared
identifier 'cppSelf'
cppSelf = ;
^
/Volumes/data2/mayadev/pyside/2.0qt56/pyside2-setup/pyside_build/py2.7-qt5.6.0-64bit-release/pyside2/PySide2/QtTest/PySide2/QtTest/qtest_wrapper.cpp:4124:15: error: expected expression
cppSelf = ;
`
The toString and toString errors are caused by changes in QtTest/qtestcase.h
#define QTEST_COMPARE_DECL(KLASS)\
template<> Q_TESTLIB_EXPORT char *toString(const KLASS &);
Qt 5.6 has the following new lines in qtestcase.h:
QTEST_COMPARE_DECL(signed char)
QTEST_COMPARE_DECL(unsigned char)
shiboken picked up the new functions in Qt 5.6
These 2 new functions could be suppressed by editing PySide2/QtTest/typesystem_test.xml
|
| |
|
|
|
|
|
|
|
|
| |
1. Heap namespace has been introduced in Qt 5.5.0.
2. Throw methods have been moved from ExecutionContext to ExecutionEngine in Qt 5.5.0.
Source 1: https://github.com/qtproject/qtdeclarative/commit/84aae25c0b3003fb846568cf26a2c7150db14d9d
Source 2: https://github.com/qtproject/qtdeclarative/commit/486948817b26da2c62802bb93a0f671715c609d4
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Fix segfault when disconnecting signal on deleted object
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
https://codereview.qt-project.org/pyside/pyside into deleted-obj-signal-segfault
From this Gerrit patch:
https://codereview.qt-project.org/#/c/110414/
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When disconnecting a signal on object that has been destroyed the
disconnect call (Sbk_QObjectFunc_disconnect) fails and returns 0 with an
error set. The calling function (signalInstanceDisconnect) was
segfaulting because it decrements the reference count of the returned
value. As the Python error is already set it's sufficient for
signalInstanceDisconnect to return 0 in this case.
Change-Id: If857961c0d64360045c1f2ba5855881e2a9aae43
Task-number: PYSIDE-189
|
|\ \ \
| | | |
| | | | |
Fix use-after-free in QProperty
|
| |\ \ \
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
https://codereview.qt-project.org/pyside/pyside into use-after-free
From this Gerrit patch:
https://codereview.qt-project.org/#/c/84452/
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
PropertyData::type() returns a new QByteArray (whose `data` is a
copy of the `char*` name of the property)
However the use of `type().data()` on the stack without saving
its reference means the `char*` returned by the `data()` method
is immediately deallocated in the the `~QByteArray` destructor.
(Detected by AddressSanitizer)
The attached patch fixes it by holding a reference to the
QByteArray returned by `type()` for the duration of the method call
Change-Id: Ia794a1215da7ba4bada19091e6d6acf3e6584c70
|
|\ \ \ \
| | | | |
| | | | | |
Fix deadlocks in some more places in signals
|
| |\ \ \ \
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://codereview.qt-project.org/pyside/pyside into fix-signal-deadlocks
From this patch:
https://codereview.qt-project.org/#/c/94249/
|
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | | |
Release GIL before connect/disconnect/emit of Qt signals.
Change-Id: Id7aa5dedb38461fb179e56d4ae9e309e9a5baa30
|
|/ / / |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
The XML names like "PySide.QtCore" go into the binaries for import, so it is necessary
to change them all. There are also hundreds of Python files which must bechanged, as well.
|
| | |
| | |
| | |
| | |
| | |
| | | |
I just understood what is needed to define a package:
The files PySide2Config(...).cmake are crucial, the project names
have little to do with that.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The intention is to have PySide2 and Shiboken2 as project names, to
allow for co-existence of PySide and PySide2.
This is the first version that builds with these settings on OS X:
$ python3 setup.py build --debug --no-examples --ignore-git --qmake=/usr/local/Cellar/qt5/5.5.0/bin/qmake --jobs=9
This is not yet tested.
|
| | |
| | |
| | |
| | | |
Qt5.5.
|
| | |
| | |
| | |
| | |
| | | |
This drastic change is just the beginning of more changes. It shows the real
problem, which was hidden due to the revision mismatch.
|
| | | |
|
| | |
| | |
| | |
| | | |
annoying warnings
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Right now, the compiling/breaking ratio on QtCore looks like 50%.
There are a couple of errors which seem to repeat all the time.
This is still work in progress, takes many hours and will hopefully result in a build, tomorrow.
|
| | |
| | |
| | |
| | | |
hunting the bug...
|
| | | |
|
|/ /
| |
| |
| | |
attempted
|
|/
|
|
|
|
|
|
|
|
|
| |
Signal connect/emit acquire a lock on the QObject, and can
happen from python code (which has acquired the GIL) or
internal QtCode (without acquiring the GIL).
So we always need to release the GIL to prevent out-of-order
acquisition of the locks causing deadlock.
Change-Id: I1cf47a73c2b60627e322d8ef3fa4c3efdebd4c02
Reviewed-by: John Ehresman <jpe@wingware.com>
|
|
|
|
|
|
|
|
|
|
| |
QCoreApplication would deadlock on exit if the global
QThreadPool.globalInstance() is running a QRunnable with python
code because the destroyQCoreApplication function would not
release the the GIL which `delete`ing the QCoreApplication.
Change-Id: I7b8a3bbd33f86050368a9357fa93e25a642b4ac5
Reviewed-by: John Ehresman <jpe@wingware.com>
|
|
|
|
|
|
|
|
|
| |
Change GlobalReceiver to explicitly 'use' [dis]connectNotify of the base
class in order to avoid hiding these with its own overloads. This fixes
the only (current) -Woverloaded-virtual warning.
Change-Id: I364b9939f9078029861054051148c319071fbbe1
Reviewed-by: John Ehresman <jpe@wingware.com>
|
|
|
|
|
|
|
|
|
| |
Add explicit casts when initializing an int[] using {}'s, as required by
C++11 to be "well formed". This fixes the only (current) -Wnarrowing
warning.
Change-Id: I7f190549a8a54a9061678a926d5478256c2084be
Reviewed-by: John Ehresman <jpe@wingware.com>
|
|
|
|
|
|
|
|
| |
Check Py_IsInitialized() in PyObjectWrapper destructor, which
can be called after interpreter shutdown
Change-Id: If9570d14a35ac3419a81846a59d972015205a858
Reviewed-by: John Cummings <jcummings2@users.sf.net>
|
|
|
|
|
|
|
|
|
|
| |
Add spaces between string literals and preprocessor symbols. These are
required because C++11 defines string prefix and suffix operators, and
confuses preprocessor tokens adjacent to string literals as unrecognized
string literal modifies, resulting in compile errors.
Change-Id: I70f4efca0acb6d2ee03327c0afbc56fe7d82c2a3
Reviewed-by: John Ehresman <jpe@wingware.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced Nokia copyrights with correct Digia copyrights.
Text in front of copyright is now retained:
** File is part of Foo, Copyright Nokia... ->
** File is part of Foo, Copyright Digia...
Replaced Nokia contact details with Digia's.
Removing "All Rights Reserved" no longer leaves an empty line.
Used the following command:
find . -path '*/3rdparty/*' -prune -o -exec grep -ilI -E
'.*Copyright.*Nokia.*|.*Contact.*' {} \; | tee >(xargs sed -i -r
'1,50 { /INdT|copy[a-z]*[ ]*=/ !{ s/(^[ \t:#*]*)([a-z ]*)
(Copyright.*Nokia.*)/
\1\2Copyright \(C\) 2013 Digia Plc and\/or its subsidiary\(-ies\)\./I
}}') >(xargs sed -i -r '1,50 s/(^[ \t:#*]*)(.*info@qt\.nokia\.com.*
|.*INSERT EMAIL ADDRESS.*|.*qt-info@nokia\.com.*
|.*qt-label1@nokia\.com.*|.*http:\/\/qt\.nokia\.com\/contact.*
|.*qt-sales@nokia\.com.*|.*http:\/\/www\.qt-project\.org\/.*)/
\1Contact: http:\/\/www\.qt-project\.org\/legal/I')
>(xargs sed -i -r '1,50{/(^[ \t:#*]*)(all rights reserved.*)/Id}')
Command now finds command details that point to qt-project.org and
changes them to qt-project.org/legal
Also no longer wrongly replaces code snippet "copyright = ..". Need to
fix these case-by-case later.
Change-Id: I4456c00202c4a2264a400bdc18c19cd097876861
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Define a getWrapperForQObject function to create / find
wrappers for QObject derived objects. It sets a property
so that an invalidate function can be called when the QObject
property is cleared in the QObject destructor after all destroyed
signal handlers have been called. Requires a change to shiboken
to generate calls to the getWrapperForQObject function.
Change-Id: I4ed548af114bf7176e8e8255a3ea70549c35d74c
Reviewed-by: Hugo Parente Lima <hugo.lima@openbossa.org>
|
|
|
|
|
| |
Change-Id: I95d3f8dd4a8473849ca19b5c8d5d59dee4c42991
Reviewed-by: Hugo Parente Lima <hugo.lima@openbossa.org>
|
|
|
|
|
|
|
|
|
| |
The callback can disconnect the slot, causing the C++ object for
the connection to be deleted. Accessing the return type would then
read already freed memory.
Change-Id: Ib33fa806978793bcac42167dd45f1e59829a3104
Reviewed-by: Marcelo Lira <marcelo.lira@openbossa.org>
|
|
|
|
|
| |
Change-Id: I876732f90690d9679537611e9a71e33aa3a4e4e3
Reviewed-by: Hugo Parente Lima <hugo.lima@openbossa.org>
|
| |
|
| |
|
|
|
|
|
|
| |
This fixes GC errors when running PySide on a Python debug env.
Reviewer: Marcelo Lira <marcelo.lira@openbossa.org>
|
|
|
|
| |
Also updated QtGui's WId conversion to Python 3.
|
| |
|
|
|
|
|
|
|
| |
Fix typos and coding style.
Signed-off-by: Paulo Alcantara <pcacjr@gmail.com>
Reviewed-by: Marcelo Lira <marcelo.lira@openbossa.org>
|