diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2016-08-30 11:17:52 +0200 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2016-08-30 13:58:39 +0000 |
commit | ad39f4355c1c6f508d8179a9af14f002c3e8a198 (patch) | |
tree | e9738eafc66103ac392341c6dcdb8e29f63c15bf | |
parent | db8b882f7791abc14f9c83bfcb74b75b4e84c709 (diff) |
Minor cleanups in clangdb autotest
- Remove unneeded destructor.
- Make members private.
- Fix comment.
Change-Id: I5bf2efcf37ae7567064fb27442e4eb6d147c4c4f
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
-rw-r--r-- | tests/auto/blackbox/tst_clangdb.cpp | 6 | ||||
-rw-r--r-- | tests/auto/blackbox/tst_clangdb.h | 13 |
2 files changed, 7 insertions, 12 deletions
diff --git a/tests/auto/blackbox/tst_clangdb.cpp b/tests/auto/blackbox/tst_clangdb.cpp index 8746a7811..e74b0c981 100644 --- a/tests/auto/blackbox/tst_clangdb.cpp +++ b/tests/auto/blackbox/tst_clangdb.cpp @@ -84,10 +84,6 @@ TestClangDb::TestClangDb() : TestBlackboxBase(SRCDIR "/testdata-clangdb", "black { } -TestClangDb::~TestClangDb() -{ -} - void TestClangDb::initTestCase() { TestBlackboxBase::initTestCase(); @@ -145,7 +141,7 @@ void TestClangDb::checkDbIsConsistentWithProject() QSKIP("MSVC command line is not self-contained"); // Validate the compile command itself, this requires a previous build since the command - // line contains 'deep' path that are creating during Qbs build run + // line contains 'deep' path that are created during Qbs build run QByteArray stdErr; QByteArray stdOut; QStringList arguments; diff --git a/tests/auto/blackbox/tst_clangdb.h b/tests/auto/blackbox/tst_clangdb.h index 1b0c68406..6769b5311 100644 --- a/tests/auto/blackbox/tst_clangdb.h +++ b/tests/auto/blackbox/tst_clangdb.h @@ -37,13 +37,6 @@ class TestClangDb : public TestBlackboxBase public: TestClangDb(); - ~TestClangDb(); - - const QString projectDir; - const QString projectFileName; - const QString buildDir; - const QString sourceFilePath; - const QString dbFilePath; private slots: void initTestCase(); @@ -56,6 +49,12 @@ private slots: private: static int runProcess(const QString &exec, const QStringList &args, QByteArray &stdErr, QByteArray &stdOut); + + const QString projectDir; + const QString projectFileName; + const QString buildDir; + const QString sourceFilePath; + const QString dbFilePath; }; #endif // Include guard. |