aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan Komissarov <ABBAPOH@gmail.com>2019-11-24 19:05:57 +0900
committerIvan Komissarov <ABBAPOH@gmail.com>2019-12-04 14:59:35 +0000
commitd8dc5e3f853f83a022bf5df60f092475fed43e7f (patch)
treedb2c73cea575e3526dd585f112181937d6f67b34
parenta8198cce40983d2e3d9385bb7cbc492ea9196026 (diff)
Use std::unique_ptr in SessionPacketReader
This allows to have a defaulted destructor Change-Id: I7c5c5819460d37f162a93319d23efaf2ad98def6 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
-rw-r--r--src/app/qbs/sessionpacketreader.cpp10
-rw-r--r--src/app/qbs/sessionpacketreader.h4
2 files changed, 8 insertions, 6 deletions
diff --git a/src/app/qbs/sessionpacketreader.cpp b/src/app/qbs/sessionpacketreader.cpp
index fe4b73f69..e99ea01ed 100644
--- a/src/app/qbs/sessionpacketreader.cpp
+++ b/src/app/qbs/sessionpacketreader.cpp
@@ -52,12 +52,12 @@ public:
SessionPacket currentPacket;
};
-SessionPacketReader::SessionPacketReader(QObject *parent) : QObject(parent), d(new Private) { }
+SessionPacketReader::SessionPacketReader(QObject *parent)
+ : QObject(parent)
+ , d(std::make_unique<Private>())
+{ }
-SessionPacketReader::~SessionPacketReader()
-{
- delete d;
-}
+SessionPacketReader::~SessionPacketReader() = default;
void SessionPacketReader::start()
{
diff --git a/src/app/qbs/sessionpacketreader.h b/src/app/qbs/sessionpacketreader.h
index e0064a14d..f186fbc8c 100644
--- a/src/app/qbs/sessionpacketreader.h
+++ b/src/app/qbs/sessionpacketreader.h
@@ -43,6 +43,8 @@
#include <QtCore/qjsonobject.h>
#include <QtCore/qobject.h>
+#include <memory>
+
namespace qbs {
namespace Internal {
@@ -61,7 +63,7 @@ signals:
private:
class Private;
- Private * const d;
+ const std::unique_ptr<Private> d;
};
} // namespace Internal