diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 13:44:43 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-12-09 18:22:51 +0000 |
| commit | f8c9a663fb2beda731c7a8d2b7ae62c4514b5f62 (patch) | |
| tree | d33fa3fc0f0685a217afab8b03895f6d1257d057 /src/app | |
| parent | 72733c1063f3e5f36af2d1d608808718ae0fda0e (diff) | |
Fix 'performance-move-const-arg' warnings
Also, treat that warning as error
In some places move is redundant (e.g. when moving int or enum), in
others it wasn't working as expected (i.e. not moving, but copying
instead), in some, const-ref was (uselessly) moved. Fix those places
Change-Id: I0b38667a71967fa35ca627990d3c12124fb62af0
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/app')
| -rw-r--r-- | src/app/qbs/session.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/app/qbs/session.cpp b/src/app/qbs/session.cpp index ee9ee4cb3..7e141b4a6 100644 --- a/src/app/qbs/session.cpp +++ b/src/app/qbs/session.cpp @@ -248,7 +248,7 @@ void Session::setupProject(const QJsonObject &request) if (m_currentJob) { if (qobject_cast<SetupProjectJob *>(m_currentJob) && m_currentJob->state() == AbstractJob::StateCanceling) { - m_resolveRequest = std::move(request); + m_resolveRequest = request; return; } sendErrorReply("project-resolved", |