aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib/api/project_p.h
diff options
context:
space:
mode:
authorIvan Komissarov <abbapoh@gmail.com>2019-12-22 16:43:32 +0200
committerIvan Komissarov <ABBAPOH@gmail.com>2020-01-06 14:36:59 +0000
commita451ec700dc679348fcf63da7cfd93469cd736f0 (patch)
treecb48d1efc6a9ae1a3b5b8053f294bb1c04dc1acc /src/lib/corelib/api/project_p.h
parentd870e416907263f5da437d1783bcda9f00fbe10e (diff)
Replace QList<Internal::ResolvedProductPtr> with QVector
QList is inefficient with shared_ptr and results in an extra allocation per each element Change-Id: I5d5492d855a233e8aec3f09a67dd4b83fb0d2c13 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/api/project_p.h')
-rw-r--r--src/lib/corelib/api/project_p.h12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/lib/corelib/api/project_p.h b/src/lib/corelib/api/project_p.h
index 283bb5be4..2afc9cd79 100644
--- a/src/lib/corelib/api/project_p.h
+++ b/src/lib/corelib/api/project_p.h
@@ -68,16 +68,16 @@ public:
}
ProjectData projectData();
- BuildJob *buildProducts(const QList<ResolvedProductPtr> &products, const BuildOptions &options,
+ BuildJob *buildProducts(const QVector<ResolvedProductPtr> &products, const BuildOptions &options,
bool needsDepencencyResolving,
QObject *jobOwner);
- CleanJob *cleanProducts(const QList<ResolvedProductPtr> &products, const CleanOptions &options,
+ CleanJob *cleanProducts(const QVector<ResolvedProductPtr> &products, const CleanOptions &options,
QObject *jobOwner);
- InstallJob *installProducts(const QList<ResolvedProductPtr> &products,
+ InstallJob *installProducts(const QVector<ResolvedProductPtr> &products,
const InstallOptions &options, bool needsDepencencyResolving,
QObject *jobOwner);
- QList<ResolvedProductPtr> internalProducts(const QList<ProductData> &products) const;
- QList<ResolvedProductPtr> allEnabledInternalProducts(bool includingNonDefault) const;
+ QVector<ResolvedProductPtr> internalProducts(const QList<ProductData> &products) const;
+ QVector<ResolvedProductPtr> allEnabledInternalProducts(bool includingNonDefault) const;
ResolvedProductPtr internalProduct(const ProductData &product) const;
ProductData findProductData(const ProductData &product) const;
QList<ProductData> findProductsByName(const QString &name) const;
@@ -92,7 +92,7 @@ public:
void setupInstallData(ArtifactData &artifact, const ResolvedProductConstPtr &product);
struct GroupUpdateContext {
- QList<ResolvedProductPtr> resolvedProducts;
+ QVector<ResolvedProductPtr> resolvedProducts;
QList<GroupPtr> resolvedGroups;
QList<ProductData> products;
QList<GroupData> groups;