Fix uninitialized variables

This fixes most of clang analyzer warnings about uninitialized variables
in ctors

Change-Id: I879c785594307ed3fe7140588338a6b2a1e4db65
Reviewed-by: Denis Shienkov <denis.shienkov@gmail.com>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

2 files changed, 20 insertions, 35 deletions

diff --git a/src/lib/corelib/api/internaljobs.cpp b/src/lib/corelib/api/internaljobs.cpp
index 95c3dc02c..652ea3cdb 100644
--- a/src/lib/corelib/api/internaljobs.cpp
+++ b/src/lib/corelib/api/internaljobs.cpp
@@ -70,7 +70,7 @@ namespace Internal {
 class JobObserver : public ProgressObserver
 {
 public:
-    JobObserver(InternalJob *job) : m_canceled(false), m_job(job), m_timedLogger(nullptr) { }
+    JobObserver(InternalJob *job) : m_job(job) { }
     ~JobObserver() { delete m_timedLogger; }
 
     void cancel()
@@ -116,12 +116,12 @@ private:
         return m_canceled;
     }
 
-    int m_value;
-    int m_maximum;
+    int m_value = 0;
+    int m_maximum = 0;
     mutable std::mutex m_cancelMutex;
-    bool m_canceled;
-    InternalJob * const m_job;
-    TimedActivityLogger *m_timedLogger;
+    bool m_canceled = false;
+    InternalJob * const m_job = nullptr;
+    TimedActivityLogger *m_timedLogger = nullptr;
 };
 
 
diff --git a/src/lib/corelib/api/projectdata_p.h b/src/lib/corelib/api/projectdata_p.h
index 69b046b0c..834aeec23 100644
--- a/src/lib/corelib/api/projectdata_p.h
+++ b/src/lib/corelib/api/projectdata_p.h
@@ -50,61 +50,49 @@ namespace Internal {
 class InstallDataPrivate : public QSharedData
 {
 public:
-    InstallDataPrivate() : isValid(false) {}
-
     QString installFilePath;
     QString installRoot;
-    bool isValid;
-    bool isInstallable;
+    bool isValid = false;
+    bool isInstallable = false;
 };
 
 class ArtifactDataPrivate : public QSharedData
 {
 public:
-    ArtifactDataPrivate() : isValid(false) {}
-
     QString filePath;
     QStringList fileTags;
     PropertyMap properties;
     InstallData installData;
-    bool isValid;
-    bool isGenerated;
-    bool isTargetArtifact;
+    bool isValid = false;
+    bool isGenerated = false;
+    bool isTargetArtifact = false;
 };
 
 class GroupDataPrivate : public QSharedData
 {
 public:
-    GroupDataPrivate() : isValid(false)
-    { }
-
     QString name;
     QString prefix;
     CodeLocation location;
     QList<ArtifactData> sourceArtifacts;
     QList<ArtifactData> sourceArtifactsFromWildcards;
     PropertyMap properties;
-    bool isEnabled;
-    bool isValid;
+    bool isEnabled = false;
+    bool isValid = false;
 };
 
 class InstallableFilePrivate: public QSharedData
 {
 public:
-    InstallableFilePrivate() : isValid(false) {}
-
     QString sourceFilePath;
     QString targetFilePath;
     QStringList fileTags;
-    bool isValid;
+    bool isValid = false;
 };
 
 class ProductDataPrivate : public QSharedData
 {
 public:
-    ProductDataPrivate() : isValid(false)
-    { }
-
     QStringList type;
     QStringList dependencies;
     QString name;
@@ -117,22 +105,19 @@ public:
     QVariantMap properties;
     PropertyMap moduleProperties;
     QList<ArtifactData> generatedArtifacts;
-    bool isEnabled;
-    bool isRunnable;
-    bool isMultiplexed;
-    bool isValid;
+    bool isEnabled = false;
+    bool isRunnable = false;
+    bool isMultiplexed = false;
+    bool isValid = false;
 };
 
 class ProjectDataPrivate : public QSharedData
 {
 public:
-    ProjectDataPrivate() : isValid(false)
-    { }
-
     QString name;
     CodeLocation location;
-    bool enabled;
-    bool isValid;
+    bool enabled = false;
+    bool isValid = false;
     QList<ProductData> products;
     QList<ProjectData> subProjects;
     QString buildDir;