diff options
author | Christian Kandeler <christian.kandeler@qt.io> | 2018-02-12 14:53:42 +0100 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@qt.io> | 2018-02-16 11:34:20 +0000 |
commit | bca41151f08e2b198bd6ac1da1603d6933c9166a (patch) | |
tree | 3d835697679d793ee5bc4434bf760929d50641fa /src/lib/corelib/buildgraph/buildgraphnode.h | |
parent | 21c5ea0f79ad0e89eaa29ab5b91387b8454c4e3e (diff) |
Get rid of redundancies between load() and store() methods
It's silly that we have to mention each serializable data member in
both the load and the store methods.
Instead, whenever possible, forward these methods to a template that calls
the right function in the persistence backend based on its parameter.
Change-Id: I00e2dee8cdf55405f447cee27190bc97df8673e3
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph/buildgraphnode.h')
-rw-r--r-- | src/lib/corelib/buildgraph/buildgraphnode.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/lib/corelib/buildgraph/buildgraphnode.h b/src/lib/corelib/buildgraph/buildgraphnode.h index ec2cddff4..44a0a5b1b 100644 --- a/src/lib/corelib/buildgraph/buildgraphnode.h +++ b/src/lib/corelib/buildgraph/buildgraphnode.h @@ -42,6 +42,7 @@ #include "nodeset.h" #include <language/forward_decls.h> +#include <tools/persistence.h> #include <tools/weakpointer.h> namespace qbs { @@ -83,11 +84,18 @@ public: bool isBuilt() const { return buildState == Built; } virtual void load(PersistentPool &pool); - virtual void store(PersistentPool &pool) const; + virtual void store(PersistentPool &pool); protected: explicit BuildGraphNode(); void acceptChildren(BuildGraphVisitor *visitor); + + // Do not store parents to avoid recursion. + // Parents must be updated after loading all nodes. + template<PersistentPool::OpType opType> void serializationOp(PersistentPool &pool) + { + pool.serializationOp<opType>(children); + } }; } // namespace Internal |