aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/corelib/buildgraph/cycledetector.h
diff options
context:
space:
mode:
authorChristian Kandeler <christian.kandeler@qt.io>2016-12-23 21:06:24 +0100
committerChristian Kandeler <christian.kandeler@qt.io>2017-01-05 09:12:13 +0000
commit88f6c8aefc377b3b0b121bf27c6b33760ca157a8 (patch)
tree71404ce0c12ca086ffaf96e4df36dd032a03e256 /src/lib/corelib/buildgraph/cycledetector.h
parent36e736977e93fcc5d4165cd25b64e9ff20c820ac (diff)
Use a sorted vector rather than QSet or std::set
========== Performance data for Resolving ========== Old instruction count: 2324724447 New instruction count: 2317712921 Relative change: -1 % Old peak memory usage: 21411584 Bytes New peak memory usage: 21070552 Bytes Relative change: -2 % ========== Performance data for Rule Execution ========== Old instruction count: 4231322611 New instruction count: 4246208129 Relative change: +0 % Old peak memory usage: 19239000 Bytes New peak memory usage: 18181072 Bytes Relative change: -6 % ========== Performance data for Null Build ========== Old instruction count: 542161499 New instruction count: 505511534 Relative change: -7 % Old peak memory usage: 13599040 Bytes New peak memory usage: 11892952 Bytes Relative change: -13 % Change-Id: I36b3dbd3fd2a4bc7503ee7779d31bd0217000785 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph/cycledetector.h')
-rw-r--r--src/lib/corelib/buildgraph/cycledetector.h7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/lib/corelib/buildgraph/cycledetector.h b/src/lib/corelib/buildgraph/cycledetector.h
index a4ebef215..a3275e0d5 100644
--- a/src/lib/corelib/buildgraph/cycledetector.h
+++ b/src/lib/corelib/buildgraph/cycledetector.h
@@ -40,11 +40,10 @@
#define QBS_CYCLEDETECTOR_H
#include "buildgraphvisitor.h"
+#include "nodeset.h"
#include <language/forward_decls.h>
#include <logging/logger.h>
-#include <QtCore/qset.h>
-
namespace qbs {
namespace Internal {
@@ -66,8 +65,8 @@ private:
QList<BuildGraphNode *> cycle(BuildGraphNode *doubleEntry);
- QSet<BuildGraphNode *> m_allNodes;
- QSet<BuildGraphNode *> m_nodesInCurrentPath;
+ NodeSet m_allNodes;
+ NodeSet m_nodesInCurrentPath;
BuildGraphNode *m_parent;
Logger m_logger;
};