diff options
| author | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-11-24 16:44:20 +0900 |
|---|---|---|
| committer | Ivan Komissarov <ABBAPOH@gmail.com> | 2019-12-02 13:45:19 +0000 |
| commit | a8198cce40983d2e3d9385bb7cbc492ea9196026 (patch) | |
| tree | f33915684717eb4744a64395e0886573778d8429 /src/lib/corelib/buildgraph/inputartifactscanner.cpp | |
| parent | 7606963ffd637aa4a410f931621af3bb982899b7 (diff) | |
Fix 'modernize-use-emplace' warnings
std::vector::emplace_back creates an object in a vector and allows to
avoid creating temporary object that is than moved into a vector. This
simplifies code a bit as it is not necessary to call std::make_pair or
use uniform initialization to create a temporary object
Change-Id: I0c5500a818f78d07bc753e25f529c06762cb615c
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Diffstat (limited to 'src/lib/corelib/buildgraph/inputartifactscanner.cpp')
| -rw-r--r-- | src/lib/corelib/buildgraph/inputartifactscanner.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/lib/corelib/buildgraph/inputartifactscanner.cpp b/src/lib/corelib/buildgraph/inputartifactscanner.cpp index ae7d456cf..14f39bb2a 100644 --- a/src/lib/corelib/buildgraph/inputartifactscanner.cpp +++ b/src/lib/corelib/buildgraph/inputartifactscanner.cpp @@ -372,7 +372,7 @@ void InputArtifactScanner::scanWithScannerPlugin(DependencyScanner *scanner, const QStringList &dependencies = scanner->collectDependencies( inputArtifact, fileToBeScanned, m_fileTagsForScanner.constData()); for (const QString &s : dependencies) - scanResult->deps.push_back(RawScannedDependency(s)); + scanResult->deps.emplace_back(s); } InputArtifactScannerContext::DependencyScannerCacheItem::DependencyScannerCacheItem() : valid(false) |