Fix recursion issue when releasing ResourceAcquiringScriptObjects

Calling releaseResourcesOfScriptObjects in QScriptEngine::evaluate does
not guarantee that the function is called in all circumstances, because
evaluate is not virtual. Worse, it might be called at the wrong time by
a recursive evaluate.

Remove the evaluate overloads, and call releaseResourcesOfScriptObjects
manually after the evaluation of
  - Probe.configure,
  - Rule.outputArtifacts,
  - Rule.prepare,
  - and JavaScriptCommand.sourceCode.

Change-Id: Ie4ed0c2d0895a13a8930d7b35c0f22a8d62dc34b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 1 insertions, 0 deletions

diff --git a/src/lib/corelib/buildgraph/jscommandexecutor.cpp b/src/lib/corelib/buildgraph/jscommandexecutor.cpp
index 1d256fa2c..3e9d35cfc 100644
--- a/src/lib/corelib/buildgraph/jscommandexecutor.cpp
+++ b/src/lib/corelib/buildgraph/jscommandexecutor.cpp
@@ -135,6 +135,7 @@ private:
         if (importScopeForSourceCode.isObject())
             scriptEngine->currentContext()->pushScope(importScopeForSourceCode);
         scriptEngine->evaluate(cmd->sourceCode());
+        scriptEngine->releaseResourcesOfScriptObjects();
         if (importScopeForSourceCode.isObject())
             scriptEngine->currentContext()->popScope();
         scriptEngine->setGlobalObject(scope.prototype());