diff options
author | Christian Kandeler <christian.kandeler@digia.com> | 2014-02-21 09:42:58 +0100 |
---|---|---|
committer | Christian Kandeler <christian.kandeler@digia.com> | 2014-02-21 14:04:34 +0100 |
commit | 2cfb04e396802455101047d5d81b1dd2ce02c874 (patch) | |
tree | 34717e6aa493b337ae68f25021958b67ca8de662 /src/lib/corelib/buildgraph/productbuilddata.h | |
parent | 5ac50ff29a88767a3d3fc104abc8c3131ab1aa10 (diff) |
Fix some sub-optimal use of the persistence facility.
- Commands were potentially saved twice, and so were their strings.
- Strings in RescuableArtifactData objects were potentially saved twice.
- Remove an unneeded include of persistence.h from a header file.
- Make all PersistentObject::{load,store} methods private to make
it clear that they may only be called via PersistentPool.
Change-Id: I17c94201dc8bc57b89132d00f3db2ec0ae2e7922
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/lib/corelib/buildgraph/productbuilddata.h')
-rw-r--r-- | src/lib/corelib/buildgraph/productbuilddata.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/lib/corelib/buildgraph/productbuilddata.h b/src/lib/corelib/buildgraph/productbuilddata.h index 8d1810b2b..5c05f2690 100644 --- a/src/lib/corelib/buildgraph/productbuilddata.h +++ b/src/lib/corelib/buildgraph/productbuilddata.h @@ -69,6 +69,7 @@ public: typedef QHash<RuleConstPtr, ArtifactSet> ArtifactSetByRule; ArtifactSetByRule artifactsWithChangedInputsPerRule; +private: void load(PersistentPool &pool); void store(PersistentPool &pool) const; }; |