Use pass-by-value and move

This fixes -Wmodernize-pass-by-value

Change-Id: I85a732867866e43c39c1d77937fbc645433c96bd
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

1 files changed, 8 insertions, 8 deletions

diff --git a/src/lib/corelib/buildgraph/productinstaller.cpp b/src/lib/corelib/buildgraph/productinstaller.cpp
index cfd74c205..d4acc9ace 100644
--- a/src/lib/corelib/buildgraph/productinstaller.cpp
+++ b/src/lib/corelib/buildgraph/productinstaller.cpp
@@ -59,14 +59,14 @@
 namespace qbs {
 namespace Internal {
 
-ProductInstaller::ProductInstaller(const TopLevelProjectPtr &project,
-        const std::vector<ResolvedProductPtr> &products, const InstallOptions &options,
-        ProgressObserver *observer, const Logger &logger)
-    : m_project(project),
-      m_products(products),
-      m_options(options),
+ProductInstaller::ProductInstaller(TopLevelProjectPtr project,
+        std::vector<ResolvedProductPtr> products, InstallOptions options,
+        ProgressObserver *observer, Logger logger)
+    : m_project(std::move(project)),
+      m_products(std::move(products)),
+      m_options(std::move(options)),
       m_observer(observer),
-      m_logger(logger)
+      m_logger(std::move(logger))
 {
     if (!m_options.installRoot().isEmpty()) {
         QFileInfo installRootFileInfo(m_options.installRoot());
@@ -85,7 +85,7 @@ ProductInstaller::ProductInstaller(const TopLevelProjectPtr &project,
         if (m_options.removeExistingInstallation())
             throw ErrorInfo(Tr::tr("Refusing to remove sysroot."));
     }
-    initInstallRoot(project.get(), m_options);
+    initInstallRoot(m_project.get(), m_options);
 }
 
 void ProductInstaller::install()